Expanding rows #30449

pkozlowski-opensource · 2019-05-14T07:41:37Z

Fixup of #30403 started by @mhevery

rebased
lint
re-format (lint was failing)
prod mode enabled
fixups to make benchpress happy

googlebot · 2019-05-14T07:41:42Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

…wEngine and Ivy

pkozlowski-opensource · 2019-05-15T15:55:11Z

modules/benchmarks/src/expanding_rows/index.html

+        }
+        // zone.js must be loaded and processed before Angular bundle gets executed
+        loadScript('/npm/node_modules/zone.js/dist/zone.js').then(function () {
+          loadScript(document.location.search.endsWith('debug') ? 'bundle.min_debug.js' : 'bundle.min.js');


This is the only reliable way of loading Angular bundle after zone.js was processed. Under Chromium version 69 used by benchpress we were randomly getting into a situation where bundle would be processed before zone.js fully loaded / executed.

pkozlowski-opensource · 2019-05-15T15:55:48Z

protractor-perf.conf.js

@@ -34,7 +34,7 @@ exports.config = {
  framework: 'jasmine2',
  jasmineNodeOpts: {
    showColors: true,
-    defaultTimeoutInterval: 60000,
+    defaultTimeoutInterval: 90000,


This particular benchmark is rather big / slow and was consistently failing on my machine without this timeout increase...

Consider leaving this as a comment in the file.

mhevery · 2019-05-15T16:04:44Z

modules/benchmarks/src/expanding_rows/benchmark_helpers.ts

+ * tries to inject an upgraded dependency. If you see these errors, mock out the
+ * upgraded service.
+ */
+export const mockInjector = {


I think this can be rmoved as we are not using angular.js here

mhevery · 2019-05-15T16:05:15Z

modules/benchmarks/src/expanding_rows/benchmark_helpers.ts

+}
+
+// Waits for Angular's testability.whenStable()
+export async function waitForStable() {


Actually I think most of these functions can be removed

You are right @mhevery - the whole file can be deleted :-) Done in a fixup commit, thnx!

mhevery · 2019-05-15T16:06:09Z

modules/benchmarks/src/expanding_rows/index.html

+        }
+        // zone.js must be loaded and processed before Angular bundle gets executed
+        loadScript('/npm/node_modules/zone.js/dist/zone.js').then(function () {
+          loadScript(document.location.search.endsWith('debug') ? 'bundle.min_debug.js' : 'bundle.min.js');


googlebot · 2019-05-15T17:09:57Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

… in ViewEngine and Ivy

googlebot · 2019-05-16T14:50:15Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

googlebot · 2019-05-16T18:51:14Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

kara · 2019-05-16T19:06:15Z

presubmit

ngbot · 2019-05-16T21:59:38Z

I see that you just added the PR action: merge label, but the following checks are still failing:
status "angular" is failing
1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

kara · 2019-05-16T22:00:43Z

merge assistance: global approval

PR Close angular#30449

…wEngine and Ivy (angular#30449) PR Close angular#30449

PR Close angular#30449

angular-automatic-lock-bot · 2019-09-15T02:22:43Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: no label May 14, 2019

pkozlowski-opensource force-pushed the expanding_rows branch 4 times, most recently from dee25ed to 2f969c7 Compare May 14, 2019 14:46

test(ivy): add expanding_rows performance benchmark which runs in Vie…

a5fcdab

…wEngine and Ivy

pkozlowski-opensource force-pushed the expanding_rows branch from 2f969c7 to 55cb85b Compare May 15, 2019 12:19

pkozlowski-opensource mentioned this pull request May 15, 2019

Expanding rows #30403

Closed

pkozlowski-opensource force-pushed the expanding_rows branch 2 times, most recently from 842db56 to d63dc7c Compare May 15, 2019 15:00

pkozlowski-opensource added 3 commits May 15, 2019 17:04

fixup! test(ivy): rebase, format and lint

f4ebb4c

fixup! test(ivy): enableProdMode

364fa3a

fixup! test(ivy): make the test run with benchpress

4877f08

pkozlowski-opensource force-pushed the expanding_rows branch from d63dc7c to 4877f08 Compare May 15, 2019 15:05

pkozlowski-opensource added comp: ivy action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels May 15, 2019

ngbot bot added this to the needsTriage milestone May 15, 2019

pkozlowski-opensource marked this pull request as ready for review May 15, 2019 15:52

pkozlowski-opensource requested review from IgorMinar and a team as code owners May 15, 2019 15:53

pkozlowski-opensource commented May 15, 2019

View reviewed changes

mhevery approved these changes May 15, 2019

View reviewed changes

mhevery added cla: yes and removed cla: no labels May 15, 2019

fixup! test(ivy): add expanding_rows performance benchmark which runs…

315c383

… in ViewEngine and Ivy

googlebot added cla: no and removed cla: yes labels May 16, 2019

kara added cla: yes and removed cla: no labels May 16, 2019

kara added action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 16, 2019

kara added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels May 16, 2019

kara added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label May 16, 2019

IgorMinar approved these changes May 17, 2019

View reviewed changes

pull bot pushed a commit to Pandinosaurus/angular that referenced this pull request May 17, 2019

fixup! test(ivy): rebase, format and lint (angular#30449)

8c1a041

PR Close angular#30449

pull bot pushed a commit to Pandinosaurus/angular that referenced this pull request May 17, 2019

fixup! test(ivy): enableProdMode (angular#30449)

a5a1f4f

PR Close angular#30449

pull bot pushed a commit to Pandinosaurus/angular that referenced this pull request May 17, 2019

fixup! test(ivy): make the test run with benchpress (angular#30449)

98ded94

PR Close angular#30449

jasonaden closed this in b1ba2d6 May 17, 2019

BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019

test(ivy): add expanding_rows performance benchmark which runs in Vie…

7c9728b

…wEngine and Ivy (angular#30449) PR Close angular#30449

BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019

fixup! test(ivy): rebase, format and lint (angular#30449)

bf8b26d

PR Close angular#30449

BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019

fixup! test(ivy): enableProdMode (angular#30449)

0b6b656

PR Close angular#30449

BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019

fixup! test(ivy): make the test run with benchpress (angular#30449)

f23f32c

PR Close angular#30449

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Expanding rows #30449

Expanding rows #30449

pkozlowski-opensource commented May 14, 2019 •

edited

googlebot commented May 14, 2019

pkozlowski-opensource May 15, 2019

mhevery May 15, 2019

pkozlowski-opensource May 15, 2019

IgorMinar May 17, 2019

mhevery May 15, 2019

mhevery May 15, 2019

pkozlowski-opensource May 16, 2019

mhevery May 15, 2019

googlebot commented May 15, 2019

googlebot commented May 16, 2019

googlebot commented May 16, 2019

kara commented May 16, 2019

ngbot bot commented May 16, 2019

kara commented May 16, 2019

angular-automatic-lock-bot bot commented Sep 15, 2019

Expanding rows #30449

Expanding rows #30449

Conversation

pkozlowski-opensource commented May 14, 2019 • edited

googlebot commented May 14, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

googlebot commented May 15, 2019

googlebot commented May 16, 2019

googlebot commented May 16, 2019

kara commented May 16, 2019

ngbot bot commented May 16, 2019

kara commented May 16, 2019

angular-automatic-lock-bot bot commented Sep 15, 2019

pkozlowski-opensource commented May 14, 2019 •

edited