Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: delete double dashes on ng command in testing guide #30551

Closed
wants to merge 1 commit into from
Closed

docs: delete double dashes on ng command in testing guide #30551

wants to merge 1 commit into from

Conversation

sandervn
Copy link
Contributor

@sandervn sandervn commented May 18, 2019

Delete unnecessary double dashes on ng command in testing guide

Closes #30550

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?>

Issue #30550

Does this PR introduce a breaking change?

  • Yes
  • No

@sandervn sandervn requested a review from a team as a code owner May 18, 2019 21:10
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you, please, remove docs-infra from the commit message (docs-infra refers to changes in the documentation infrastructure; not actual content). E.g.:

docs: delete double dashes on ng command in testing guide

Closes #30550

@gkalpak gkalpak added comp: docs action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels May 20, 2019
@ngbot ngbot bot modified the milestone: needsTriage May 20, 2019
@gkalpak gkalpak added the target: patch This PR is targeted for the next patch release label May 20, 2019
@brandonroberts brandonroberts added effort1: hours risk: low refactoring Issue that involves refactoring or code-cleanup labels May 20, 2019
@ngbot ngbot bot modified the milestones: needsTriage, Backlog May 20, 2019
@brandonroberts brandonroberts added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels May 20, 2019
@ngbot
Copy link

ngbot bot commented May 20, 2019

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci-codefresh-bazel" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@brandonroberts
Copy link
Contributor

Caretaker note: The Codefresh build failure is unrelated

@brandonroberts brandonroberts changed the title docs(docs-infra): delete double dashes ng command docs: delete double dashes on ng command in testing guide May 21, 2019
@brandonroberts brandonroberts added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label May 21, 2019
@brandonroberts brandonroberts self-assigned this May 21, 2019
@jasonaden jasonaden closed this in 7c0667d May 21, 2019
@sandervn sandervn deleted the change-ng-command-aio-testing-guide branch May 22, 2019 14:59
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note refactoring Issue that involves refactoring or code-cleanup risk: low target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary double dashes in ng command under testing guide on aio
4 participants