Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): cleanup code with side-effects which was preventing t… #30580

Closed
wants to merge 3 commits into from
Closed

refactor(core): cleanup code with side-effects which was preventing t… #30580

wants to merge 3 commits into from

Conversation

mhevery
Copy link
Contributor

@mhevery mhevery commented May 21, 2019

…ree-shaking

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@mhevery mhevery requested review from a team as code owners May 21, 2019 05:50
@jasonaden jasonaden added the area: core Issues related to the framework runtime label May 21, 2019
@ngbot ngbot bot added this to the needsTriage milestone May 21, 2019
@mhevery mhevery requested a review from a team as a code owner May 21, 2019 16:58
@mhevery mhevery added the target: major This PR is targeted for the next major release label May 21, 2019
@mhevery mhevery added the action: merge The PR is ready for merge by the caretaker label May 21, 2019
IgorMinar
IgorMinar approved these changes May 21, 2019
View reviewed changes
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move the comment into constructor of QueryList

@mhevery
Copy link
Contributor Author

mhevery commented May 21, 2019

fixed comment.

filipesilva
filipesilva approved these changes May 21, 2019
View reviewed changes
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Just left a couple of small comments from my side.

packages/core/src/util/ng_i18n_closure_mode.ts Show resolved Hide resolved
packages/core/src/util/ng_i18n_closure_mode.ts Show resolved Hide resolved
@matsko matsko removed the action: merge The PR is ready for merge by the caretaker label May 24, 2019
@matsko
Copy link
Contributor

matsko commented May 24, 2019

please fix up the tests and rebase.

@mhevery mhevery requested a review from a team as a code owner May 31, 2019 23:17
@mhevery mhevery added the action: merge The PR is ready for merge by the caretaker label Jun 2, 2019
@mhevery mhevery closed this in fcdd784 Jun 3, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trotyl trotyl trotyl left review comments

@IgorMinar IgorMinar IgorMinar approved these changes

@filipesilva filipesilva filipesilva approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mhevery @matsko @IgorMinar @filipesilva @trotyl @jasonaden @googlebot