Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ivy): add ɵɵupdateSyntheticHostBinding command #30670

Conversation

benlesh
Copy link
Contributor

@benlesh benlesh commented May 25, 2019

  • Refactors ɵɵcomponentHostSyntheticProperty into ɵɵupdateSyntheticHostBinding, to better align it with other new instructions.

@benlesh benlesh added state: WIP refactoring Issue that involves refactoring or code-cleanup target: major This PR is targeted for the next major release comp: ivy risk: low labels May 25, 2019
@ngbot ngbot bot added this to the needsTriage milestone May 25, 2019
@benlesh benlesh marked this pull request as ready for review May 28, 2019 16:49
@benlesh benlesh requested review from a team as code owners May 28, 2019 16:49
@benlesh benlesh added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note action: review The PR is still awaiting reviews from at least one requested reviewer and removed merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels May 29, 2019
@ngbot
Copy link

ngbot bot commented May 29, 2019

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci-codefresh-bazel" is failing
    failure status "ci/circleci: test_aio_local_ivy" is failing
    pending status "google3" is pending
    pending missing required status "ci/circleci: publish_snapshot"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@benlesh benlesh requested a review from alxhub May 29, 2019 15:52
@gkalpak gkalpak removed the action: merge The PR is ready for merge by the caretaker label May 29, 2019
@gkalpak
Copy link
Member

gkalpak commented May 29, 2019

@benlesh, I removed the merge label, to avoid accidentally merging this.
The test_aio_local_ivy failures are valid. (It seems like the whole app is broken. In a fundamental way 😁 It seems as if the browser enters an infinite loop or something (at least when trying to navigate to certain pages) 😕)

@benlesh benlesh force-pushed the refactor_componentHostSyntheticProperty branch 2 times, most recently from 1d76571 to 55f60c3 Compare May 31, 2019 16:23
- Refactors `ɵɵcomponentHostSyntheticProperty` into `ɵɵupdateSyntheticHostBinding`, to better align it with other new instructions.
@benlesh benlesh force-pushed the refactor_componentHostSyntheticProperty branch from 55f60c3 to 7ce7af0 Compare May 31, 2019 16:37
@benlesh benlesh added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 31, 2019
@benlesh
Copy link
Contributor Author

benlesh commented May 31, 2019

presubmit

@benlesh benlesh added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label May 31, 2019
@benlesh
Copy link
Contributor Author

benlesh commented May 31, 2019

Caretaker: google3 passed, for some reason when I force it green it occasionally pops back to red. Not sure what's going on there. Also globally approved for public-api by @mhevery

@benlesh benlesh added action: presubmit The PR is in need of a google3 presubmit and removed merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels May 31, 2019
@benlesh
Copy link
Contributor Author

benlesh commented May 31, 2019

oops, needs ivy presubmit

@benlesh
Copy link
Contributor Author

benlesh commented May 31, 2019

ivy presubmit

@benlesh
Copy link
Contributor Author

benlesh commented May 31, 2019

Caretaker: Ivy presubmit looks normal.

@benlesh benlesh added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: presubmit The PR is in need of a google3 presubmit labels May 31, 2019
@mhevery mhevery closed this in b4e6802 Jun 3, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note refactoring Issue that involves refactoring or code-cleanup risk: low target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants