Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove core.module.ts from file tree in style guide #30679

Closed
wants to merge 1 commit into from

Conversation

lacolaco
Copy link
Contributor

@lacolaco lacolaco commented May 27, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

After #28434 merged, core.module.ts is left in the styleguide.

What is the new behavior?

core.module.ts has been removed.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@lacolaco lacolaco requested a review from a team as a code owner May 27, 2019 05:14
@brandonroberts brandonroberts added comp: docs effort1: hours target: patch This PR is targeted for the next patch release risk: low state: community Someone from the Angular community is working on this issue or submitted this PR refactoring Issue that involves refactoring or code-cleanup labels May 28, 2019
@brandonroberts brandonroberts self-assigned this May 28, 2019
@ngbot ngbot bot added this to the Backlog milestone May 28, 2019
@brandonroberts brandonroberts added comp: misc action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels May 28, 2019
@brandonroberts brandonroberts removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label May 28, 2019
@brandonroberts brandonroberts changed the title docs(styleguide): remove core.module.ts from file tree docs: remove core.module.ts from file tree in style guide May 28, 2019
@lacolaco
Copy link
Contributor Author

Thank you for fixing my commit message.

@brandonroberts brandonroberts added the action: merge The PR is ready for merge by the caretaker label May 28, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours refactoring Issue that involves refactoring or code-cleanup risk: low state: community Someone from the Angular community is working on this issue or submitted this PR target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants