Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove mention of project settings from analytics #30701

Closed
wants to merge 1 commit into from

Conversation

clydin
Copy link
Member

@clydin clydin commented May 28, 2019

These settings are not yet implemented and will be available in 8.1.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Analytics project settings are not yet implemented in 8.0 but are present in the documentation.

What is the new behavior?

References to analytics project settings have been removed.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This settings are not yet implemented and will be available in 8.1.
@clydin clydin requested a review from a team as a code owner May 28, 2019 17:47
@brandonroberts brandonroberts added comp: docs effort1: hours target: patch This PR is targeted for the next patch release risk: low refactoring Issue that involves refactoring or code-cleanup labels May 28, 2019
@ngbot ngbot bot added this to the Backlog milestone May 28, 2019
@alexeagle alexeagle added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label May 28, 2019
@ngbot ngbot bot added the action: merge The PR is ready for merge by the caretaker label May 28, 2019
@ngbot
Copy link

ngbot bot commented May 28, 2019

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "pullapprove" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@matsko matsko closed this in f5b0c8a May 30, 2019
matsko pushed a commit that referenced this pull request May 30, 2019
This settings are not yet implemented and will be available in 8.1.

PR Close #30701
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note refactoring Issue that involves refactoring or code-cleanup risk: low target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants