Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: rename component for constructor example #30845

Closed
wants to merge 1 commit into from
Closed

docs: rename component for constructor example #30845

wants to merge 1 commit into from

Conversation

PandiyanCool
Copy link
Contributor

@PandiyanCool PandiyanCool commented Jun 4, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #30730

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@PandiyanCool PandiyanCool requested a review from a team as a code owner June 4, 2019 12:14
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@PandiyanCool
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@PandiyanCool
Copy link
Contributor Author

Related to #30730

@kapunahelewong kapunahelewong added comp: docs effort1: hours freq1: low target: patch This PR is targeted for the next patch release risk: medium state: community Someone from the Angular community is working on this issue or submitted this PR type: bug/fix labels Jun 4, 2019
@ngbot ngbot bot added this to the Backlog milestone Jun 4, 2019
@brandonroberts brandonroberts self-assigned this Jun 4, 2019
@brandonroberts brandonroberts added the action: merge The PR is ready for merge by the caretaker label Jun 4, 2019
@brandonroberts
Copy link
Contributor

Thanks @PandiyanCool!

mhevery pushed a commit that referenced this pull request Jun 4, 2019
@mhevery mhevery closed this in 3ed7463 Jun 4, 2019
@PandiyanCool PandiyanCool deleted the patch-1 branch June 6, 2019 03:54
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours freq1: low risk: medium state: community Someone from the Angular community is working on this issue or submitted this PR target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants