Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ivy): allow empty cases for ICU expressions #30846

Closed
wants to merge 1 commit into from
Closed

fix(ivy): allow empty cases for ICU expressions #30846

wants to merge 1 commit into from

Conversation

ocombe
Copy link
Contributor

@ocombe ocombe commented Jun 4, 2019

We used to ignore empty strings for optimization purposes, but it turns out that empty strings are also valid values for ICU cases and we shouldn't ignore those.

@ocombe ocombe added type: bug/fix action: review The PR is still awaiting reviews from at least one requested reviewer area: i18n target: major This PR is targeted for the next major release comp: ivy risk: low labels Jun 4, 2019
@ocombe ocombe requested a review from AndrewKushnir June 4, 2019 13:09
@ocombe ocombe requested review from a team as code owners June 4, 2019 13:09
@ngbot ngbot bot added this to the needsTriage milestone Jun 4, 2019
@ocombe
fix(ivy): allow empty cases for ICU expressions
276702f 
We used to ignore empty strings for optimization purposes, but it turns out that empty strings are also valid values for ICU cases and we shouldn't ignore those.

FW-1290 #resolve
@ocombe ocombe force-pushed the fix/ivy/fw-1290-empty-icus branch from 0fe17b1 to 276702f Compare June 4, 2019 14:30
AndrewKushnir
AndrewKushnir approved these changes Jun 4, 2019
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@AndrewKushnir AndrewKushnir added action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 4, 2019
@AndrewKushnir
Copy link
Contributor

Presubmit

@kara
Copy link
Contributor

kara commented Jun 4, 2019

@AndrewKushnir Can we also do an Ivy presubmit?

@AndrewKushnir
Copy link
Contributor

Ivy presubmit

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels Jun 4, 2019
@mhevery mhevery closed this in 0d4f8c7 Jun 4, 2019
@ocombe ocombe deleted the fix/ivy/fw-1290-empty-icus branch June 4, 2019 21:01
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

@AndrewKushnir AndrewKushnir

Labels
action: merge The PR is ready for merge by the caretaker area: i18n cla: yes risk: low target: major This PR is targeted for the next major release type: bug/fix
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ocombe @AndrewKushnir @kara @googlebot