Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transpiler: add unit tests #30

Closed
vojtajina opened this issue Sep 29, 2014 · 4 comments
Closed

transpiler: add unit tests #30

vojtajina opened this issue Sep 29, 2014 · 4 comments

Comments

@vojtajina
Copy link
Contributor

No description provided.

@tbosch
Copy link
Contributor

tbosch commented Oct 1, 2014

Hi Vojta,
Could you add more details about which parts of the transpiler need more
tests, as there already are some...

On Monday, September 29, 2014, Vojta Jina notifications@github.com wrote:


Reply to this email directly or view it on GitHub
#30.

@vicb
Copy link
Contributor

vicb commented Oct 1, 2014

One thing I discussed with @vojtajina is to unit test each of transformers (like this is done for Traceur).

Some advantages:

  • could help to understand the code (it's not easy to review a PR - I realized that when I tried to review the PR from @vsavkin),
  • currently we only do some integration tests no unit test - ie we can not assert that the transformer will fail & how,
  • we could add to disabled test for TODO features

@alexeagle
Copy link
Contributor

I added a unit test for the dart transpiler in
e20d9dd
Does that resolve this issue? Or do we also want some example of unit testing a particular transformer, or of transpiling to ES5?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants