ci: temporarily disable payload size tracking #31057
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `CIRCLE_COMPARE_URL` is not available in builds any more since we enabled `Pipelines` on CircleCI. We have contected CircleCI, but until this is solved we cannot get the commit range and thus disabling uploading of payload size data to avoid broken builds.
filipesilva
approved these changes
Jun 14, 2019
AndrewKushnir
added
action: merge
AndrewKushnir
pushed a commit
that referenced
this pull request
Jun 14, 2019
The `CIRCLE_COMPARE_URL` is not available in builds any more since we enabled `Pipelines` on CircleCI. We have contected CircleCI, but until this is solved we cannot get the commit range and thus disabling uploading of payload size data to avoid broken builds. PR Close #31057
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Jun 19, 2019
Payload size tracking was temporarily disabled in angular#31057, due to `CIRCLE_COMPARE_URL` stopping being available. It turned out this was related to turning on the new [Pipelines][1] feature, which was required for testing Windows on CircleCI. Since then, we have turned `Pipelines` off and got `CIRCLE_COMPARE_URL` back (e.g. see [build 362971][2]). According to CircleCI, failing to populate `CIRCLE_COMPARE_URL` with `Pipelines` on is a bug and they are working on fixing it. [1]: https://circleci.com/docs/2.0/build-processing/ [2]: https://circleci.com/gh/angular/angular/362971 Fixes angular#31121
kara
pushed a commit
that referenced
this pull request
Jun 19, 2019
Payload size tracking was temporarily disabled in #31057, due to `CIRCLE_COMPARE_URL` stopping being available. It turned out this was related to turning on the new [Pipelines][1] feature, which was required for testing Windows on CircleCI. Since then, we have turned `Pipelines` off and got `CIRCLE_COMPARE_URL` back (e.g. see [build 362971][2]). According to CircleCI, failing to populate `CIRCLE_COMPARE_URL` with `Pipelines` on is a bug and they are working on fixing it. [1]: https://circleci.com/docs/2.0/build-processing/ [2]: https://circleci.com/gh/angular/angular/362971 Fixes #31121 PR Close #31138
kara
pushed a commit
that referenced
this pull request
Jun 19, 2019
Payload size tracking was temporarily disabled in #31057, due to `CIRCLE_COMPARE_URL` stopping being available. It turned out this was related to turning on the new [Pipelines][1] feature, which was required for testing Windows on CircleCI. Since then, we have turned `Pipelines` off and got `CIRCLE_COMPARE_URL` back (e.g. see [build 362971][2]). According to CircleCI, failing to populate `CIRCLE_COMPARE_URL` with `Pipelines` on is a bug and they are working on fixing it. [1]: https://circleci.com/docs/2.0/build-processing/ [2]: https://circleci.com/gh/angular/angular/362971 Fixes #31121 PR Close #31138
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CIRCLE_COMPARE_URLis not available in builds any more since we enabledPipelineson CircleCI. We have contected CircleCI, but until this is solved we cannot get the commit range and thus disabling uploading of payload size data to avoid broken builds.