Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add mock heroes to the code review tabs #31080

Closed
wants to merge 1 commit into from

Conversation

erikologic
Copy link
Contributor

@erikologic erikologic commented Jun 16, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@erikologic erikologic requested a review from a team as a code owner June 16, 2019 17:37
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@erikologic
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@mary-poppins
Copy link

You can preview ad64bd8 at https://pr31080-ad64bd8.ngbuilds.io/.

@brandonroberts brandonroberts added comp: docs effort1: hours target: patch This PR is targeted for the next patch release risk: low state: community Someone from the Angular community is working on this issue or submitted this PR feature Issue that requests a new feature labels Jun 17, 2019
@ngbot ngbot bot modified the milestone: Backlog Jun 17, 2019
Copy link
Contributor

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the (docs-infra) scope from the git commit message

aio/content/tutorial/toh-pt2.md Show resolved Hide resolved
@brandonroberts brandonroberts self-assigned this Jun 17, 2019
@brandonroberts brandonroberts added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jun 17, 2019
@brandonroberts brandonroberts removed the request for review from sreevani-ship-it June 17, 2019 13:59
@brandonroberts brandonroberts changed the title Added src/app/mock-heroes.ts docs: add mock heroes to the code review tabs Jun 17, 2019
@brandonroberts brandonroberts added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jun 17, 2019
@mary-poppins
Copy link

You can preview c208391 at https://pr31080-c208391.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 43564c3 at https://pr31080-43564c3.ngbuilds.io/.

@brandonroberts
Copy link
Contributor

@mrenrich84 this git commit message should in present tense. Update to docs: add mock heroes to the code review tabs for TOH pt. 2

@mary-poppins
Copy link

You can preview d31fef4 at https://pr31080-d31fef4.ngbuilds.io/.

@brandonroberts brandonroberts removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jun 17, 2019
@brandonroberts brandonroberts added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Jun 17, 2019
@ngbot ngbot bot added the action: merge The PR is ready for merge by the caretaker label Jun 17, 2019
@ngbot
Copy link

ngbot bot commented Jun 17, 2019

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: integration_test" is failing
    pending status "ci-codefresh-bazel" is pending
    pending missing required status "ci/circleci: publish_snapshot"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@brandonroberts
Copy link
Contributor

Caretaker note: integration_test failure is unrelated

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker aio: preview cla: yes effort1: hours feature Issue that requests a new feature merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note risk: low state: community Someone from the Angular community is working on this issue or submitted this PR target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants