New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix testing example #31120
docs: fix testing example #31120
Conversation
4622cf3
to
c5dc439
Compare
You can preview 4622cf3 at https://pr31120-4622cf3.ngbuilds.io/. |
You can preview c5dc439 at https://pr31120-c5dc439.ngbuilds.io/. |
c5dc439
to
a484f1d
Compare
You can preview a484f1d at https://pr31120-a484f1d.ngbuilds.io/. |
a484f1d
to
ae7481f
Compare
You can preview ae7481f at https://pr31120-ae7481f.ngbuilds.io/. |
Not sure why the unrelated For |
ae7481f
to
1ba103c
Compare
You can preview 1ba103c at https://pr31120-1ba103c.ngbuilds.io/. |
1ba103c
to
3cc26ab
Compare
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
3cc26ab
to
7f5e96f
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
You can preview 06ba417 at https://pr31120-06ba417.ngbuilds.io/. |
06ba417
to
b5dfc9c
Compare
You can preview b5dfc9c at https://pr31120-b5dfc9c.ngbuilds.io/. |
You can preview 1abe825 at https://pr31120-1abe825.ngbuilds.io/. |
@brandonroberts is this ready to merge or are you waiting for the other pending reviewers? If you want to override the pending reviews, just add a "merge assistance" label (we've been using "merge" as auto-submit) |
@kara its ready to merge |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Testing example (the test one - there are two examples), is broken. The tests render the screen as empty bullet points.
Issue Number:
Closes #30939
Closes ##30137
What is the new behavior?
Tests render correctly.
Does this PR introduce a breaking change?
Other information
Original fixes from @brandonroberts work. Thanks, Brandon! 🦢