Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix testing example #31120

Closed

Conversation

kapunahelewong
Copy link
Contributor

@kapunahelewong kapunahelewong commented Jun 18, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Testing example (the test one - there are two examples), is broken. The tests render the screen as empty bullet points.

Issue Number:
Closes #30939
Closes ##30137

What is the new behavior?

Tests render correctly.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Original fixes from @brandonroberts work. Thanks, Brandon! 🦢

@mary-poppins
Copy link

You can preview 4622cf3 at https://pr31120-4622cf3.ngbuilds.io/.

@mary-poppins
Copy link

You can preview c5dc439 at https://pr31120-c5dc439.ngbuilds.io/.

@mary-poppins
Copy link

You can preview a484f1d at https://pr31120-a484f1d.ngbuilds.io/.

@mary-poppins
Copy link

You can preview ae7481f at https://pr31120-ae7481f.ngbuilds.io/.

@brandonroberts
Copy link
Contributor

Not sure why the unrelated http tests are failing all the sudden, but there needs to be types added:

For hero https://github.com/angular/angular/blob/master/aio/content/examples/http/src/app/heroes/heroes.component.ts#L53
For entry https://github.com/angular/angular/blob/master/aio/content/examples/http/src/app/package-search/package-search.service.ts#L51

@mary-poppins
Copy link

You can preview 1ba103c at https://pr31120-1ba103c.ngbuilds.io/.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot removed the cla: no label Jun 19, 2019
@mary-poppins
Copy link

You can preview 06ba417 at https://pr31120-06ba417.ngbuilds.io/.

@mary-poppins
Copy link

You can preview b5dfc9c at https://pr31120-b5dfc9c.ngbuilds.io/.

@brandonroberts brandonroberts removed the request for review from a team June 20, 2019 15:13
@kapunahelewong kapunahelewong changed the title [WIP] docs: testing example fix docs: testing example fix Jun 20, 2019
@kapunahelewong kapunahelewong changed the title docs: testing example fix docs: fix testing example Jun 20, 2019
@brandonroberts brandonroberts added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jun 21, 2019
@mary-poppins
Copy link

You can preview 1abe825 at https://pr31120-1abe825.ngbuilds.io/.

@brandonroberts brandonroberts added target: patch This PR is targeted for the next patch release and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jun 25, 2019
@brandonroberts brandonroberts added the action: merge The PR is ready for merge by the caretaker label Jun 25, 2019
@kara
Copy link
Contributor

kara commented Jun 25, 2019

@brandonroberts is this ready to merge or are you waiting for the other pending reviewers? If you want to override the pending reviews, just add a "merge assistance" label (we've been using "merge" as auto-submit)

@kara kara added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jun 25, 2019
@brandonroberts brandonroberts added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Jun 25, 2019
@brandonroberts
Copy link
Contributor

brandonroberts commented Jun 25, 2019

@kara its ready to merge

@brandonroberts brandonroberts removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Jun 25, 2019
@kara kara closed this in 02d98ed Jun 25, 2019
kara pushed a commit that referenced this pull request Jun 25, 2019
kara pushed a commit that referenced this pull request Jun 25, 2019
kara pushed a commit that referenced this pull request Jun 25, 2019
alxhub pushed a commit to petebacondarwin/angular that referenced this pull request Jun 25, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours freq3: high merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note risk: medium target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs(aio): Testing example app doesn't work since Angular 8
5 participants