Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router API doc edit #31476

Closed
wants to merge 1 commit into from
Closed

Conversation

jbogarthyde
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

Updating API doc for Router structures and utilities.
Organizing, editing and rewriting existing doc for consistency, style, and completeness.

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Not touching Directives in this PR.

@jbogarthyde jbogarthyde added type: bug/fix comp: docs effort3: weeks freq3: high area: router aio: preview target: patch This PR is targeted for the next patch release state: needs eng review Needs technical review and approval from engineering team labels Jul 9, 2019
@jbogarthyde jbogarthyde requested a review from a team as a code owner July 9, 2019 21:35
@ngbot ngbot bot added this to the needsTriage milestone Jul 9, 2019
@mary-poppins
Copy link

You can preview 8be9598 at https://pr31476-8be9598.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 94b1215 at https://pr31476-94b1215.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 15a2070 at https://pr31476-15a2070.ngbuilds.io/.

@dennispbrown dennispbrown added this to In Progress in docs Jul 10, 2019
@jbogarthyde jbogarthyde force-pushed the jb-apidoc-router branch 2 times, most recently from 93d5f60 to f136460 Compare July 10, 2019 17:06
@mary-poppins
Copy link

You can preview f136460 at https://pr31476-f136460.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 93d5f60 at https://pr31476-93d5f60.ngbuilds.io/.

@jbogarthyde jbogarthyde requested a review from a team as a code owner July 10, 2019 18:33
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@mary-poppins
Copy link

You can preview 4ace529 at https://pr31476-4ace529.ngbuilds.io/.

@mary-poppins
Copy link

You can preview b67e47b at https://pr31476-b67e47b.ngbuilds.io/.

@ngbot ngbot bot modified the milestones: needsTriage, Backlog Jul 12, 2019
@jbogarthyde jbogarthyde added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Jul 15, 2019
@ngbot ngbot bot added the action: merge The PR is ready for merge by the caretaker label Jul 15, 2019
@ngbot
Copy link

ngbot bot commented Jul 15, 2019

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci-codefresh-bazel" is failing
    pending status "google3" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jbogarthyde jbogarthyde removed the action: merge The PR is ready for merge by the caretaker label Jul 15, 2019
@jbogarthyde jbogarthyde force-pushed the jb-apidoc-router branch 2 times, most recently from 03d291c to 939eba1 Compare July 15, 2019 16:55
@mary-poppins
Copy link

You can preview 03d291c at https://pr31476-03d291c.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 939eba1 at https://pr31476-939eba1.ngbuilds.io/.

@jbogarthyde jbogarthyde moved this from In Progress to In Review in docs Jul 15, 2019
@jbogarthyde jbogarthyde moved this from In Review to Waiting for Approval in docs Jul 15, 2019
@IgorMinar IgorMinar added the action: merge The PR is ready for merge by the caretaker label Jul 17, 2019
@ngbot
Copy link

ngbot bot commented Jul 17, 2019

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: aio_preview" is failing
    failure status "ci/circleci: test_aio" is failing
    pending status "google3" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mary-poppins
Copy link

You can preview 0f54b7a at https://pr31476-0f54b7a.ngbuilds.io/.

@jbogarthyde jbogarthyde moved this from Waiting for Approval to Waiting for Merge in docs Jul 17, 2019
@jbogarthyde
Copy link
Contributor Author

Doc only, shouldn't need G3

mhevery pushed a commit that referenced this pull request Jul 18, 2019
@mhevery mhevery closed this in 1e9eeaf Jul 18, 2019
@jbogarthyde jbogarthyde deleted the jb-apidoc-router branch July 22, 2019 15:09
@jbogarthyde jbogarthyde moved this from Waiting for Merge to Done in docs Jul 22, 2019
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker aio: preview area: router cla: yes effort3: weeks freq3: high merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note risk: low state: needs eng review Needs technical review and approval from engineering team target: patch This PR is targeted for the next patch release type: bug/fix
Projects
docs
Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants