New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Router API doc edit #31476
Router API doc edit #31476
Conversation
You can preview 8be9598 at https://pr31476-8be9598.ngbuilds.io/. |
You can preview 94b1215 at https://pr31476-94b1215.ngbuilds.io/. |
You can preview 15a2070 at https://pr31476-15a2070.ngbuilds.io/. |
93d5f60
to
f136460
Compare
You can preview f136460 at https://pr31476-f136460.ngbuilds.io/. |
You can preview 93d5f60 at https://pr31476-93d5f60.ngbuilds.io/. |
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
You can preview 4ace529 at https://pr31476-4ace529.ngbuilds.io/. |
You can preview b67e47b at https://pr31476-b67e47b.ngbuilds.io/. |
03d291c
to
939eba1
Compare
You can preview 03d291c at https://pr31476-03d291c.ngbuilds.io/. |
You can preview 939eba1 at https://pr31476-939eba1.ngbuilds.io/. |
939eba1
to
0f54b7a
Compare
You can preview 0f54b7a at https://pr31476-0f54b7a.ngbuilds.io/. |
Doc only, shouldn't need G3 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
Updating API doc for Router structures and utilities.
Organizing, editing and rewriting existing doc for consistency, style, and completeness.
Does this PR introduce a breaking change?
Other information
Not touching Directives in this PR.