test(ivy): test against recent Material commit #31569

JoostK · 2019-07-15T15:51:37Z

Updating material-unit-tests to run against master with Bazel

.circleci/config.yml

devversion

LGTM.

.circleci/config.yml

scripts/ci/run_angular_material_unit_tests.sh

.circleci/config.yml

scripts/ci/run_angular_material_unit_tests.sh

JoostK · 2019-07-16T20:39:19Z

I notice now that all tests are run in both Chromium and Firefox, compared to only Chromium when we were using gulp. The total job duration has increased from ~3:30 to 7:30, which is quite a severe regression. @devversion Can we disable the Firefox targets using a filter? That should hopefully help to reduce the execution time.

josephperrott · 2019-07-16T20:49:09Z

@JoostK We have a tag that you can target:

Example: https://github.com/angular/components/blob/master/package.json#L21 shows only targeting chromium-local

bazel test //src/... --test_tag_filters=-e2e,-browser:firefox-local --build_tag_filters=-browser:firefox-local

googlebot · 2019-07-23T15:01:43Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

.circleci/config.yml

scripts/ci/update-deps-to-dist-packages.js

Previously, the ivy-2019 branch of the Material (aka components) repo was used, which contains some changes that were necessary to work with Ivy. These changes are not longer necessary, as Material's master branch is fully working with Ivy today. To be up-to-date with recent Material development and its support for more recent dependencies, e.g. TypeScript, it is desirable for us to be on a newer version of Material. This commit moves the Material tests away from the ivy-2019 branch, to a recent commit on master. We are not targeting the master branch itself, as that would introduce a moving target into Angular's CI checks, which is undesirable. Lastly, the usage of gulp to run Material's tests is changed into using Bazel, as Material itself is now also built with Bazel.

No longer locks the Material unit tests job to a specific branch, but rather allows locking to a specific commit from a given branch. This allows us to use the "master" branch from the `components` repository.

JoostK · 2019-07-25T17:40:19Z

We typically target master & patch for build related PRs, however the Material tests might not run correctly on the patch version (which is lacking Ivy fixes). So regarding the target, I propose this is targeting only master and I will open another PR targeting patch to see if it's green and can be merged into patch.

gkalpak

🎉

No longer locks the Material unit tests job to a specific branch, but rather allows locking to a specific commit from a given branch. This allows us to use the "master" branch from the `components` repository. PR Close #31569

…ar#31569) Previously, the ivy-2019 branch of the Material (aka components) repo was used, which contains some changes that were necessary to work with Ivy. These changes are not longer necessary, as Material's master branch is fully working with Ivy today. To be up-to-date with recent Material development and its support for more recent dependencies, e.g. TypeScript, it is desirable for us to be on a newer version of Material. This commit moves the Material tests away from the ivy-2019 branch, to a recent commit on master. We are not targeting the master branch itself, as that would introduce a moving target into Angular's CI checks, which is undesirable. Lastly, the usage of gulp to run Material's tests is changed into using Bazel, as Material itself is now also built with Bazel. PR Close angular#31569

No longer locks the Material unit tests job to a specific branch, but rather allows locking to a specific commit from a given branch. This allows us to use the "master" branch from the `components` repository. PR Close angular#31569

… (#31847) Previously, the ivy-2019 branch of the Material (aka components) repo was used, which contains some changes that were necessary to work with Ivy. These changes are not longer necessary, as Material's master branch is fully working with Ivy today. To be up-to-date with recent Material development and its support for more recent dependencies, e.g. TypeScript, it is desirable for us to be on a newer version of Material. This commit moves the Material tests away from the ivy-2019 branch, to a recent commit on master. We are not targeting the master branch itself, as that would introduce a moving target into Angular's CI checks, which is undesirable. Lastly, the usage of gulp to run Material's tests is changed into using Bazel, as Material itself is now also built with Bazel. PR Close #31569 PR Close #31847

No longer locks the Material unit tests job to a specific branch, but rather allows locking to a specific commit from a given branch. This allows us to use the "master" branch from the `components` repository. PR Close #31569 PR Close #31847

…ar#31569) Previously, the ivy-2019 branch of the Material (aka components) repo was used, which contains some changes that were necessary to work with Ivy. These changes are not longer necessary, as Material's master branch is fully working with Ivy today. To be up-to-date with recent Material development and its support for more recent dependencies, e.g. TypeScript, it is desirable for us to be on a newer version of Material. This commit moves the Material tests away from the ivy-2019 branch, to a recent commit on master. We are not targeting the master branch itself, as that would introduce a moving target into Angular's CI checks, which is undesirable. Lastly, the usage of gulp to run Material's tests is changed into using Bazel, as Material itself is now also built with Bazel. PR Close angular#31569

No longer locks the Material unit tests job to a specific branch, but rather allows locking to a specific commit from a given branch. This allows us to use the "master" branch from the `components` repository. PR Close angular#31569

angular-automatic-lock-bot · 2019-09-15T08:51:33Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

JoostK added state: WIP refactoring Issue that involves refactoring or code-cleanup comp: ivy labels Jul 15, 2019

ngbot bot added this to the needsTriage milestone Jul 15, 2019

googlebot added the cla: yes label Jul 15, 2019

JoostK force-pushed the update-material-unit-tests branch 2 times, most recently from 09eaa1f to c06f68b Compare July 16, 2019 16:42

JoostK commented Jul 16, 2019

View reviewed changes

.circleci/config.yml Outdated Show resolved Hide resolved

JoostK marked this pull request as ready for review July 16, 2019 17:08

JoostK requested a review from a team as a code owner July 16, 2019 17:08

JoostK requested review from devversion and josephperrott July 16, 2019 17:08

JoostK changed the title ~~test(ivy): test against Material master branch~~ test(ivy): test against stable Material tag Jul 16, 2019

JoostK added action: review The PR is still awaiting reviews from at least one requested reviewer PR target: TBD and removed state: WIP labels Jul 16, 2019

devversion approved these changes Jul 16, 2019

View reviewed changes

.circleci/config.yml Outdated Show resolved Hide resolved

.circleci/config.yml Show resolved Hide resolved

scripts/ci/run_angular_material_unit_tests.sh Outdated Show resolved Hide resolved

devversion added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jul 16, 2019

josephperrott reviewed Jul 16, 2019

View reviewed changes

.circleci/config.yml Outdated Show resolved Hide resolved

scripts/ci/run_angular_material_unit_tests.sh Show resolved Hide resolved

JoostK requested a review from gkalpak July 16, 2019 20:28

JoostK force-pushed the update-material-unit-tests branch from 6e4edef to 79a965a Compare July 16, 2019 20:59

JoostK removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jul 16, 2019

JoostK force-pushed the update-material-unit-tests branch from 79a965a to ec7a1a5 Compare July 18, 2019 16:36

googlebot added cla: no and removed cla: yes labels Jul 23, 2019

devversion force-pushed the update-material-unit-tests branch 2 times, most recently from 35e036c to bc9413f Compare July 23, 2019 15:31

JoostK added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jul 24, 2019

kara requested a review from gkalpak July 24, 2019 22:38

gkalpak requested changes Jul 25, 2019

View reviewed changes

JoostK force-pushed the update-material-unit-tests branch from 02bcd6c to 710d971 Compare July 25, 2019 16:51

JoostK and others added 5 commits July 25, 2019 19:11

build: lock material unit tests job to specific commit

bc82792

No longer locks the Material unit tests job to a specific branch, but rather allows locking to a specific commit from a given branch. This allows us to use the "master" branch from the `components` repository.

fixup! build: lock material unit tests job to specific commit

f79b735

fixup! test(ivy): update Material to recent commit from master branch

ee96863

fixup! build: lock material unit tests job to specific commit

3fea0b1

JoostK force-pushed the update-material-unit-tests branch from 710d971 to 3fea0b1 Compare July 25, 2019 17:12

alxhub added target: major This PR is targeted for the next major release and removed PR target: TBD action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 25, 2019

kara unassigned JoostK Jul 25, 2019

kara requested a review from gkalpak July 25, 2019 17:50

gkalpak approved these changes Jul 25, 2019

View reviewed changes

kara added the action: merge The PR is ready for merge by the caretaker label Jul 25, 2019

mhevery closed this in 7e46a6d Jul 25, 2019

JoostK mentioned this pull request Jul 25, 2019

Update material tests patch #31847

Closed

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019

JoostK deleted the update-material-unit-tests branch September 15, 2019 13:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(ivy): test against recent Material commit #31569

test(ivy): test against recent Material commit #31569

JoostK commented Jul 15, 2019

devversion left a comment

JoostK commented Jul 16, 2019

josephperrott commented Jul 16, 2019

googlebot commented Jul 23, 2019

JoostK commented Jul 25, 2019

gkalpak left a comment

angular-automatic-lock-bot bot commented Sep 15, 2019

test(ivy): test against recent Material commit #31569

test(ivy): test against recent Material commit #31569

Conversation

JoostK commented Jul 15, 2019

devversion left a comment

Choose a reason for hiding this comment

JoostK commented Jul 16, 2019

josephperrott commented Jul 16, 2019

googlebot commented Jul 23, 2019

JoostK commented Jul 25, 2019

gkalpak left a comment

Choose a reason for hiding this comment

angular-automatic-lock-bot bot commented Sep 15, 2019