Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ivy): correct circular dependency which causes g3 failures #31665

Closed
wants to merge 2 commits into from
Closed

refactor(ivy): correct circular dependency which causes g3 failures #31665

wants to merge 2 commits into from

Conversation

mhevery
Copy link
Contributor

@mhevery mhevery commented Jul 19, 2019

No description provided.

@mhevery mhevery requested review from a team as code owners July 19, 2019 20:07
kara
kara approved these changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhevery mhevery requested a review from a team as a code owner July 19, 2019 20:16
kara
kara approved these changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added the comp: ivy label Jul 19, 2019
@ngbot ngbot bot added this to the needsTriage milestone Jul 19, 2019
@kara kara added action: presubmit The PR is in need of a google3 presubmit target: major This PR is targeted for the next major release action: merge The PR is ready for merge by the caretaker labels Jul 19, 2019
@kara kara changed the title refactor(ivy): correct circular dependency which acuses g3 failures refactor(ivy): correct circular dependency which causes g3 failures Jul 19, 2019
@kara
Copy link
Contributor

kara commented Jul 19, 2019 •
edited

VE presubmit

Ivy presubmit

@kara kara added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: presubmit The PR is in need of a google3 presubmit labels Jul 19, 2019
@kara
Copy link
Contributor

kara commented Jul 19, 2019

merge-assistance: global approval

@kara kara closed this in f14693b Jul 19, 2019
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
@mhevery @sabeersulaiman
refactor(ivy): correct circular dependency which causes g3 failures (a…
d76a92e 
…ngular#31665)

PR Close angular#31665
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kara kara kara approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mhevery @kara @googlebot