Set of performance improvements #31839

pkozlowski-opensource · 2019-07-25T12:32:04Z

No description provided.

mhevery · 2019-07-25T21:16:30Z

packages/core/src/render3/PERF_NOTES.md

@@ -22,6 +22,18 @@ Great reads:

 See benchmark [here](https://jsperf.com/mono-vs-megamorphic-property-access).

+## Packed vs. holey Array


thanks for adding this!

mhevery · 2019-07-25T21:22:36Z

packages/core/src/render3/instructions/shared.ts

+  const blueprint = ngDevMode ? new LViewBlueprint !(initialViewLength) :
+                                Array.apply(null, Array(initialViewLength));
+
+  blueprint.fill(null, 0, bindingStartIndex).fill(NO_CHANGE, bindingStartIndex) as LView;


I think there is much better way to do this.

const blueprint = ngDevMode ? new LViewBlueprint !() : []; blueprint.fill(null, 0, bindingStartIndex).fill(NO_CHANGE, bindingStartIndex, initialViewLength) as LView;

This won't work as .fill doesn't write past the array length. I've pushed an alternative (if we don't want to use the "apply" trick):

const blueprint = ngDevMode ? new LViewBlueprint !() : []; for (let i = 0; i < initialViewLength; i++) { blueprint.push(i < bindingStartIndex ? null : NO_CHANGE); }

Really? OK.

ngbot · 2019-07-29T08:01:04Z

I see that you just added the PR action: merge label, but the following checks are still failing:
status "ci-codefresh-bazel" is failing
status "google3" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

AndrewKushnir · 2019-07-29T17:18:54Z

Adding "cleanup" label to indicate that the size limit needs an update (as per discussion due the team sync), so that test_aio_local_ivy CircleCI task passes.

…ven view

setPreviousOrParentTNode is set in enterView so no need to reset it just before entering a view.

…ries defined

pkozlowski-opensource · 2019-07-30T14:36:57Z

@AndrewKushnir I've updated the size limit, as discussed. I did it in a separate commit and update to the same value as in the @crisbeto PR #31845 so we are not generating conflicts (or can drop the commit in question if needed).

petebacondarwin

perf(aio): update main bundle size

This does not seem like the correct commit message.

the subject we use is now docs-infra (aio is deprecated as a subject)
should it be type perf? I would expect build or ci or even test

Also it would be really helpful for future readers if you explain in the commit message why this has been done (and mention the discussion).

PR angular#31839 contains perf and code cleanup changes that add 48 bytes to the main bundle size. Perf gains and code clarity justify this increase. Unfortunately the size verification job is rejecting this PR as it reports size gains from a fixed size and not relative increase of size from a particular PR. It was decided during the internal team discussion to bump up size limits to correctly reflect current state of the master and increase from this PR.

AndrewKushnir · 2019-07-30T17:18:03Z

PR Close #31839

…ven view (#31839) PR Close #31839

…31839) setPreviousOrParentTNode is set in enterView so no need to reset it just before entering a view. PR Close #31839

…ries defined (#31839) PR Close #31839

PR Close #31839

PR #31839 contains perf and code cleanup changes that add 48 bytes to the main bundle size. Perf gains and code clarity justify this increase. Unfortunately the size verification job is rejecting this PR as it reports size gains from a fixed size and not relative increase of size from a particular PR. It was decided during the internal team discussion to bump up size limits to correctly reflect current state of the master and increase from this PR. PR Close #31839

PR Close angular#31839

…ar#31839) PR Close angular#31839

…ven view (angular#31839) PR Close angular#31839

…ngular#31839) setPreviousOrParentTNode is set in enterView so no need to reset it just before entering a view. PR Close angular#31839

…ries defined (angular#31839) PR Close angular#31839

PR Close angular#31839

PR angular#31839 contains perf and code cleanup changes that add 48 bytes to the main bundle size. Perf gains and code clarity justify this increase. Unfortunately the size verification job is rejecting this PR as it reports size gains from a fixed size and not relative increase of size from a particular PR. It was decided during the internal team discussion to bump up size limits to correctly reflect current state of the master and increase from this PR. PR Close angular#31839

angular-automatic-lock-bot · 2019-09-15T09:20:39Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Jul 25, 2019

pkozlowski-opensource force-pushed the benchmark_and_improvements branch from f03bc28 to 2646f3c Compare July 25, 2019 14:34

pkozlowski-opensource added comp: ivy action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Jul 25, 2019

ngbot bot added this to the needsTriage milestone Jul 25, 2019

pkozlowski-opensource mentioned this pull request Jul 25, 2019

Ivy perf improvements 2019 07 24 #31822

Closed

pkozlowski-opensource changed the title ~~Benchmark and improvements~~ Set of performance improvements Jul 25, 2019

mhevery suggested changes Jul 25, 2019

View reviewed changes

pkozlowski-opensource force-pushed the benchmark_and_improvements branch 2 times, most recently from 9a738d8 to 98a4a57 Compare July 26, 2019 12:30

pkozlowski-opensource marked this pull request as ready for review July 26, 2019 14:21

pkozlowski-opensource requested a review from a team as a code owner July 26, 2019 14:21

mhevery approved these changes Jul 26, 2019

View reviewed changes

mhevery removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Jul 26, 2019

pkozlowski-opensource added the action: merge The PR is ready for merge by the caretaker label Jul 29, 2019

pkozlowski-opensource force-pushed the benchmark_and_improvements branch from 98a4a57 to 6b70b59 Compare July 29, 2019 08:46

AndrewKushnir added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jul 29, 2019

crisbeto mentioned this pull request Jul 30, 2019

fix(ivy): DebugElement.triggerEventHandler not picking up events registered via Renderer2 #31845

Closed

pkozlowski-opensource added 8 commits July 30, 2019 16:08

perf(ivy): avoid repeated tView.firstTemplatePass writes

27a7b27

refactor(ivy): rewrite refreshDynamicEmbeddedViews for clarity

e0f9d17

perf(ivy): only refresh child components if those are defined in a gi…

0b7d59d

…ven view

refactor(ivy): remove unnecessary call to setPreviousOrParentTNode

308ee01

setPreviousOrParentTNode is set in enterView so no need to reset it just before entering a view.

perf(ivy): call refreshContentQueries only when there are content que…

91415f9

…ries defined

perf(ivy): stricter null checks

255f397

perf(ivy): limit creationMode checks

4fb5fec

perf(ivy): avoid creating holey LView Arrays

d5945aa

pkozlowski-opensource force-pushed the benchmark_and_improvements branch from 6b70b59 to be908c7 Compare July 30, 2019 14:09

petebacondarwin approved these changes Jul 30, 2019

View reviewed changes

petebacondarwin added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jul 30, 2019

pkozlowski-opensource force-pushed the benchmark_and_improvements branch from 1c22891 to e6b598a Compare July 30, 2019 16:07

pkozlowski-opensource force-pushed the benchmark_and_improvements branch from e6b598a to 65798b7 Compare July 30, 2019 16:32

AndrewKushnir added the action: presubmit The PR is in need of a google3 presubmit label Jul 30, 2019

pkozlowski-opensource removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jul 30, 2019

AndrewKushnir removed the action: presubmit The PR is in need of a google3 presubmit label Jul 30, 2019

AndrewKushnir closed this in a77d0e2 Jul 30, 2019

AndrewKushnir pushed a commit that referenced this pull request Jul 30, 2019

refactor(ivy): rewrite refreshDynamicEmbeddedViews for clarity (#31839)

e08391b

PR Close #31839

AndrewKushnir pushed a commit that referenced this pull request Jul 30, 2019

perf(ivy): only refresh child components if those are defined in a gi…

430124a

…ven view (#31839) PR Close #31839

AndrewKushnir pushed a commit that referenced this pull request Jul 30, 2019

refactor(ivy): remove unnecessary call to setPreviousOrParentTNode (#…

a4bc0db

…31839) setPreviousOrParentTNode is set in enterView so no need to reset it just before entering a view. PR Close #31839

AndrewKushnir pushed a commit that referenced this pull request Jul 30, 2019

perf(ivy): call refreshContentQueries only when there are content que…

c0317d4

…ries defined (#31839) PR Close #31839

AndrewKushnir pushed a commit that referenced this pull request Jul 30, 2019

perf(ivy): stricter null checks (#31839)

561ec6a

PR Close #31839

AndrewKushnir pushed a commit that referenced this pull request Jul 30, 2019

perf(ivy): limit creationMode checks (#31839)

a9ec3db

PR Close #31839

AndrewKushnir pushed a commit that referenced this pull request Jul 30, 2019

perf(ivy): avoid creating holey LView Arrays (#31839)

78659ec

PR Close #31839

sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019

perf(ivy): avoid repeated tView.firstTemplatePass writes (angular#31839)

12ec389

PR Close angular#31839

sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019

refactor(ivy): rewrite refreshDynamicEmbeddedViews for clarity (angul…

b7ee3b5

…ar#31839) PR Close angular#31839

sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019

perf(ivy): only refresh child components if those are defined in a gi…

88dc54d

…ven view (angular#31839) PR Close angular#31839

sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019

perf(ivy): call refreshContentQueries only when there are content que…

bcb9d9e

…ries defined (angular#31839) PR Close angular#31839

sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019

perf(ivy): stricter null checks (angular#31839)

3b4b7cf

PR Close angular#31839

sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019

perf(ivy): limit creationMode checks (angular#31839)

1e3d4f4

PR Close angular#31839

sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019

perf(ivy): avoid creating holey LView Arrays (angular#31839)

e3e40be

PR Close angular#31839

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set of performance improvements #31839

Set of performance improvements #31839

pkozlowski-opensource commented Jul 25, 2019

mhevery Jul 25, 2019

mhevery Jul 25, 2019

pkozlowski-opensource Jul 26, 2019

mhevery Jul 26, 2019

ngbot bot commented Jul 29, 2019

AndrewKushnir commented Jul 29, 2019

pkozlowski-opensource commented Jul 30, 2019 •

edited

petebacondarwin left a comment

AndrewKushnir commented Jul 30, 2019

angular-automatic-lock-bot bot commented Sep 15, 2019

		@@ -22,6 +22,18 @@ Great reads:

		See benchmark [here](https://jsperf.com/mono-vs-megamorphic-property-access).

		## Packed vs. holey Array

Set of performance improvements #31839

Set of performance improvements #31839

Conversation

pkozlowski-opensource commented Jul 25, 2019

mhevery Jul 25, 2019

Choose a reason for hiding this comment

mhevery Jul 25, 2019

Choose a reason for hiding this comment

pkozlowski-opensource Jul 26, 2019

Choose a reason for hiding this comment

mhevery Jul 26, 2019

Choose a reason for hiding this comment

ngbot bot commented Jul 29, 2019

AndrewKushnir commented Jul 29, 2019

pkozlowski-opensource commented Jul 30, 2019 • edited

petebacondarwin left a comment

Choose a reason for hiding this comment

AndrewKushnir commented Jul 30, 2019

angular-automatic-lock-bot bot commented Sep 15, 2019

pkozlowski-opensource commented Jul 30, 2019 •

edited