Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(zone.js): update changelog of zone.js #31915

Closed
wants to merge 2 commits into from

Conversation

JiaLiPassion
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the new behavior?

update the changelog pf zone.js

Does this PR introduce a breaking change?

  • Yes
  • No

@JiaLiPassion JiaLiPassion requested review from a team as code owners July 30, 2019 21:24
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@JiaLiPassion JiaLiPassion force-pushed the changelog-1 branch 2 times, most recently from 581f492 to 2759375 Compare August 1, 2019 19:54
tools/gulp-tasks/changelog-zonejs.js Outdated Show resolved Hide resolved
tools/gulp-tasks/changelog-zonejs.js Outdated Show resolved Hide resolved
packages/zone.js/DEVELOPER.md Outdated Show resolved Hide resolved
@JiaLiPassion
Copy link
Contributor Author

@gkalpak , I updated the PR, update the gulp file to make sure the version is output correctly (zone version instead of angular version), also handle the feedback you give. Thanks!

@JiaLiPassion JiaLiPassion force-pushed the changelog-1 branch 5 times, most recently from 12b80f4 to 76eccfe Compare August 2, 2019 00:38
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Aug 2, 2019
@JiaLiPassion JiaLiPassion force-pushed the changelog-1 branch 2 times, most recently from 4036d04 to 13a05d8 Compare August 2, 2019 11:46
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@mhevery mhevery added area: zones action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Aug 2, 2019
@ngbot ngbot bot added this to the needsTriage milestone Aug 2, 2019
@mhevery mhevery added target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Aug 2, 2019
alxhub pushed a commit that referenced this pull request Aug 2, 2019
@alxhub alxhub closed this in fa4e170 Aug 2, 2019
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: zones cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants