Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: change to global approvers in codeowners #31940

Closed
wants to merge 1 commit into from

Conversation

jenniferfell
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?
Changes CODEOWNERS to remove myself from global approvers for doc edits.

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe: CODEOWNERS change

What is the current behavior?

I'm in the group @angular/framework-global-approvers-for-docs-only-changes.

Issue Number: N/A

What is the new behavior?

I'm no longer part of the group @angular/framework-global-approvers-for-docs-only-changes.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@ngbot ngbot bot modified the milestone: needsTriage Aug 1, 2019
@kapunahelewong kapunahelewong added effort1: hours target: patch This PR is targeted for the next patch release risk: low type: bug/fix labels Aug 1, 2019
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Aug 1, 2019
@kapunahelewong kapunahelewong added this to Waiting for Approval in docs Aug 1, 2019
@IgorMinar IgorMinar added the action: merge The PR is ready for merge by the caretaker label Aug 20, 2019
AndrewKushnir pushed a commit that referenced this pull request Aug 20, 2019
@kapunahelewong kapunahelewong moved this from Waiting for Approval to Done in docs Aug 21, 2019
ngdevelop-tech pushed a commit to ngdevelop-tech/angular that referenced this pull request Aug 27, 2019
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours risk: low target: patch This PR is targeted for the next patch release type: bug/fix
Projects
docs
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants