refactor(ivy): remove load instruction #32067
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
action: review
alfaproject
reviewed
Aug 9, 2019
pkozlowski-opensource
approved these changes
Aug 9, 2019
There was a problem hiding this comment.
LGTM, thnx @crisbeto - it was on my TODO list!
If you into those type of changes we could also replace ɵɵloadViewQuery and ɵɵloadContentQuery with just one instruction ( ɵɵloadQuery ?) as the 2 mentioned functions are the same now.
|
Cool! Will do next week. |
AndrewKushnir
added
the
action: presubmit
kara
added
action: cleanup
crisbeto
force-pushed
the
load-instruction-cleanup
branch
2 times, most recently
from
9c54561
to
bb25717
Compare
crisbeto
added
the
action: review
crisbeto
removed
the
action: cleanup
|
I've reworked in based on the feedback @kara. |
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Aug 12, 2019
Combines the `loadViewQuery` and `loadContentQuery` instructions since they have the exact same internal logic. Based on a discussion here: angular#32067 (review)
kara
pushed a commit
that referenced
this pull request
Aug 12, 2019
Combines the `loadViewQuery` and `loadContentQuery` instructions since they have the exact same internal logic. Based on a discussion here: #32067 (review) PR Close #32100
kara
removed
the
action: review
kara
added
the
action: cleanup
These changes remove the `ɵɵload` instruction which isn't being generated anymore.
crisbeto
force-pushed
the
load-instruction-cleanup
branch
from
bb25717
to
5ff529e
Compare
crisbeto
added
action: merge
kara
added
merge: caretaker note
|
merge-assistance: global approval |
sabeersulaiman
pushed a commit
to sabeersulaiman/angular
that referenced
this pull request
Sep 6, 2019
Combines the `loadViewQuery` and `loadContentQuery` instructions since they have the exact same internal logic. Based on a discussion here: angular#32067 (review) PR Close angular#32100
sabeersulaiman
pushed a commit
to sabeersulaiman/angular
that referenced
this pull request
Sep 6, 2019
These changes remove the `ɵɵload` instruction which isn't being generated anymore. PR Close angular#32067
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes remove the
ɵɵloadinstruction which isn't being generated anymore.