Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add info about reviewing PRs from code owners #32108

Closed
wants to merge 2 commits into from
Closed

docs: add info about reviewing PRs from code owners #32108

wants to merge 2 commits into from

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Aug 12, 2019

☝️

@gkalpak gkalpak added comp: docs action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Aug 12, 2019
@ngbot ngbot bot modified the milestone: needsTriage Aug 12, 2019
kara
kara approved these changes Aug 12, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit

docs/TRIAGE_AND_LABELS.md Outdated Show resolved Hide resolved
@kara kara added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Aug 12, 2019
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Aug 13, 2019
@kapunahelewong kapunahelewong added this to Waiting for Approval in docs Aug 13, 2019
@kapunahelewong kapunahelewong moved this from Waiting for Approval to In Review in docs Aug 13, 2019
@kara kara assigned gkalpak and unassigned gkalpak Aug 13, 2019
@gkalpak @kara
fixup! docs: add info about reviewing PRs from code owners
46aa721 
Co-Authored-By: Kara <kara@users.noreply.github.com>
@gkalpak gkalpak removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Aug 14, 2019
@kara kara added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Aug 14, 2019
@kara
Copy link
Contributor

kara commented Aug 14, 2019

merge-assistance: global approval

AndrewKushnir pushed a commit that referenced this pull request Aug 14, 2019
@gkalpak @AndrewKushnir
docs: add info about reviewing PRs from code owners (#32108)
da44498 
PR Close #32108
@gkalpak gkalpak deleted the docs-review-pr-info branch August 14, 2019 19:45
@kapunahelewong kapunahelewong moved this from In Review to Waiting for Merge in docs Aug 21, 2019
@kapunahelewong kapunahelewong moved this from Waiting for Merge to Done in docs Aug 21, 2019
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
@gkalpak @sabeersulaiman
docs: add info about reviewing PRs from code owners (angular#32108)
1f2e144 
PR Close angular#32108
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kara kara kara approved these changes

@IgorMinar IgorMinar Awaiting requested review from IgorMinar

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note risk: low target: patch This PR is targeted for the next patch release type: bug/fix
Projects
docs
Done
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gkalpak @kara @kapunahelewong @googlebot