New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add detail to Router NavigationCancel event doc #32140
Conversation
You can preview e135ad0 at https://pr32140-e135ad0.ngbuilds.io/. |
Thanks for making the PR :) I wanted to work on this issue as well in order to start contributing. Even prepared a small commit earlier today. My change looks like this: /**
* An event triggered when a navigation is canceled.
*
* The event is triggered when a route guard:
*
* * returns `false`
* * initiates a redirect by returning a {@link UrlTree}
*
* @publicApi
*/ I've also deleted the sentence Maybe you can do that as well? |
Thanks! Will do. |
You can preview 4b986f2 at https://pr32140-4b986f2.ngbuilds.io/. |
You can preview d5ee07b at https://pr32140-d5ee07b.ngbuilds.io/. |
d1a4d5e
to
4a9518d
Compare
You can preview d1a4d5e at https://pr32140-d1a4d5e.ngbuilds.io/. |
You can preview 4a9518d at https://pr32140-4a9518d.ngbuilds.io/. |
4a9518d
to
3af85fd
Compare
You can preview 3af85fd at https://pr32140-3af85fd.ngbuilds.io/. |
3af85fd
to
b8fbd7f
Compare
You can preview b8fbd7f at https://pr32140-b8fbd7f.ngbuilds.io/. |
b8fbd7f
to
14d9e0c
Compare
You can preview 14d9e0c at https://pr32140-14d9e0c.ngbuilds.io/. |
14d9e0c
to
3a2427e
Compare
You can preview 3a2427e at https://pr32140-3a2427e.ngbuilds.io/. |
Doc only, should not need G3. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Description of event trigger is minimal.
Issue Number: #32096
What is the new behavior?
Expands description with cases where nav is canceled indirectly.
Does this PR introduce a breaking change?