Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add ngcc as a valid commit message scope #32144

Closed
wants to merge 1 commit into from
Closed

build: add ngcc as a valid commit message scope #32144

wants to merge 1 commit into from

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Aug 14, 2019

☝️

@gkalpak gkalpak requested review from IgorMinar and a team as code owners August 14, 2019 21:38
@gkalpak gkalpak added area: build & ci Related the build and CI infrastructure of the project action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Aug 14, 2019
@ngbot ngbot bot added this to the needsTriage milestone Aug 14, 2019
@mhevery mhevery added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Aug 15, 2019
@mhevery
Copy link
Contributor

mhevery commented Aug 15, 2019

MERGE-ASSISTANCE: Using my global approve powers to make this PR green.

AndrewKushnir pushed a commit that referenced this pull request Aug 15, 2019
@gkalpak @AndrewKushnir
build: add ngcc as a valid commit message scope (#32144)
adc869f 
PR Close #32144
@gkalpak gkalpak deleted the build-ngcc-scope branch August 16, 2019 13:58
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
@gkalpak @sabeersulaiman
build: add ngcc as a valid commit message scope (angular#32144)
344338c 
PR Close angular#32144
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhevery mhevery mhevery approved these changes

@devversion devversion devversion approved these changes

@IgorMinar IgorMinar Awaiting requested review from IgorMinar

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gkalpak @mhevery @devversion @googlebot