refactor(language-service): Omit typechecking for finding directives #32156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyliau
added
area: language-service
ayazhafiz
requested changes
Aug 15, 2019
Remove unnecessary private method `getDeclarationFromNode` and moved some logic to utils instead so that it can be tested in isolation of the Language Service infrastructure. The use of typechecker to check the directive is also not necessary, since resolve.getNonNormalizedDirectiveMetadata() will check if the directive is actually an Angular entity.
ayazhafiz
approved these changes
Aug 16, 2019
ngdevelop-tech
pushed a commit
to ngdevelop-tech/angular
that referenced
this pull request
Aug 27, 2019
…ngular#32156) Remove unnecessary private method `getDeclarationFromNode` and moved some logic to utils instead so that it can be tested in isolation of the Language Service infrastructure. The use of typechecker to check the directive is also not necessary, since resolve.getNonNormalizedDirectiveMetadata() will check if the directive is actually an Angular entity. PR Close angular#32156
sabeersulaiman
pushed a commit
to sabeersulaiman/angular
that referenced
this pull request
Sep 6, 2019
…ngular#32156) Remove unnecessary private method `getDeclarationFromNode` and moved some logic to utils instead so that it can be tested in isolation of the Language Service infrastructure. The use of typechecker to check the directive is also not necessary, since resolve.getNonNormalizedDirectiveMetadata() will check if the directive is actually an Angular entity. PR Close angular#32156
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary private method
getDeclarationFromNodeand movedsome logic to utils instead so that it can be tested in isolation of the
Language Service infrastructure.
The use of typechecker to check the directive is also not necessary,
since
resolver.getNonNormalizedDirectiveMetadata()will check if thedirective is actually an Angular entity.
Misc:
getTightestNode()getClassDeclFromTemplateNode()PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information