build: add blocklist for material unit tests #32239
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initially the blocklist has been removed because there were no remaining disabled tests that failed. Also the blocklist logic didn't work anymore because the `material-unit-tests` CI job now runs against `angular/components#master` with Bazel. 388578f tried to revert the removal of the blocklist in favor of a new upcoming breaking change with HammerJS, but the revert doesn't help since the blocklist still doesn't work with Bazel. In order to make the blocklist work with the unit tests running with Bazel, a PR has been submitted on the components repository. See: angular/components#16833. This commit updates the blocklist logic on the framework side to work with the new logic on the components repo side.
devversion
added
state: blocked
action: review
kara
approved these changes
Aug 21, 2019
|
|
||
| Each property in the blocklist object corresponds to a test in the components | ||
| repository. The name of the property **must** match the exact test name. Additionally | ||
| it's **recommended** that every entry has a field with a note on why the test is disabled. |
kara
added
action: merge
|
Blocked on angular/components#16833 |
|
This PR is now unblocked as angular/components#16833 has merged |
kara
added
the
area: build & ci
|
We still need to update the SHA for the Not a problem though, it would have been a separate commit anyway. |
ngdevelop-tech
pushed a commit
to ngdevelop-tech/angular
that referenced
this pull request
Aug 27, 2019
Initially the blocklist has been removed because there were no remaining disabled tests that failed. Also the blocklist logic didn't work anymore because the `material-unit-tests` CI job now runs against `angular/components#master` with Bazel. 388578f tried to revert the removal of the blocklist in favor of a new upcoming breaking change with HammerJS, but the revert doesn't help since the blocklist still doesn't work with Bazel. In order to make the blocklist work with the unit tests running with Bazel, a PR has been submitted on the components repository. See: angular/components#16833. This commit updates the blocklist logic on the framework side to work with the new logic on the components repo side. PR Close angular#32239
sabeersulaiman
pushed a commit
to sabeersulaiman/angular
that referenced
this pull request
Sep 6, 2019
Initially the blocklist has been removed because there were no remaining disabled tests that failed. Also the blocklist logic didn't work anymore because the `material-unit-tests` CI job now runs against `angular/components#master` with Bazel. 388578f tried to revert the removal of the blocklist in favor of a new upcoming breaking change with HammerJS, but the revert doesn't help since the blocklist still doesn't work with Bazel. In order to make the blocklist work with the unit tests running with Bazel, a PR has been submitted on the components repository. See: angular/components#16833. This commit updates the blocklist logic on the framework side to work with the new logic on the components repo side. PR Close angular#32239
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially the blocklist has been removed because there were
no remaining disabled tests that failed. Also the blocklist
logic didn't work anymore because the
material-unit-testsCIjob now runs against
angular/components#masterwith Bazel.388578f tried to revert the removal of the blocklist in favor
of a new upcoming breaking change with HammerJS, but the
revert doesn't help since the blocklist still doesn't work with Bazel.
In order to make the blocklist work with the unit tests running
with Bazel, a PR has been submitted on the components repository.
See: angular/components#16833.
This commit updates the blocklist logic on the framework side to
work with the new logic on the components repo side.