Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: copy bazelrc files to home RC locations #32251

Closed
wants to merge 1 commit into from
Closed

ci: copy bazelrc files to home RC locations #32251

wants to merge 1 commit into from

Conversation

josephperrott
Copy link
Member

Copy CircleCI .bazelrc files as home RC file rather than system RC file (as outlined here).

This results in our CircleCI bazelrc config being loaded later than our .bazelrc next to the WORKSPACE file, so its rules are interpretted later and therefore are used when in conflict with the .bazelrc file next to WORKSPACE

@josephperrott josephperrott requested a review from a team as a code owner August 21, 2019 23:07
@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release area: build & ci Related the build and CI infrastructure of the project labels Aug 21, 2019
@ngbot ngbot bot added this to the needsTriage milestone Aug 21, 2019
@atscott atscott closed this in a367b90 Aug 22, 2019
@josephperrott josephperrott deleted the use-workers branch August 22, 2019 14:27
ngdevelop-tech pushed a commit to ngdevelop-tech/angular that referenced this pull request Aug 27, 2019
@josephperrott @ngdevelop-tech
ci: copy bazelrc files to home RC locations (angular#32251)
6d6a6b2 
PR Close angular#32251
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
@josephperrott @sabeersulaiman
ci: copy bazelrc files to home RC locations (angular#32251)
bfc574d 
PR Close angular#32251
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IgorMinar IgorMinar IgorMinar approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@josephperrott @IgorMinar @googlebot