Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add information about running clang-format with Vim #32254

Closed
wants to merge 1 commit into from

Conversation

ayazhafiz
Copy link
Member

A clang-format plugin for Vim must point to the npm-installed
clang-format command. Add docs for this.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

A clang-format plugin for Vim must point to the npm-installed
clang-format command. Add docs for this.
@ayazhafiz ayazhafiz added comp: docs target: major This PR is targeted for the next major release labels Aug 22, 2019
@ayazhafiz ayazhafiz self-assigned this Aug 22, 2019
@ngbot ngbot bot modified the milestone: needsTriage Aug 22, 2019
@kapunahelewong kapunahelewong added effort1: hours risk: low feature Issue that requests a new feature labels Aug 22, 2019
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Aug 22, 2019
@kapunahelewong kapunahelewong added the state: needs eng review Needs technical review and approval from engineering team label Aug 22, 2019
@kapunahelewong kapunahelewong added this to Need Assistance from Eng. in docs Aug 22, 2019
@kapunahelewong kapunahelewong removed the state: needs eng review Needs technical review and approval from engineering team label Aug 22, 2019
@kapunahelewong kapunahelewong moved this from Need Assistance from Eng. to In Review in docs Aug 22, 2019
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Aug 22, 2019
atscott pushed a commit that referenced this pull request Aug 22, 2019
A clang-format plugin for Vim must point to the npm-installed
clang-format command. Add docs for this.

PR Close #32254
@atscott atscott closed this in 3dd614d Aug 22, 2019
@kapunahelewong kapunahelewong moved this from In Review to Waiting for Approval in docs Aug 26, 2019
@kapunahelewong kapunahelewong moved this from Waiting for Approval to Waiting for Merge in docs Aug 26, 2019
@kapunahelewong kapunahelewong moved this from Waiting for Merge to Done in docs Aug 26, 2019
ngdevelop-tech pushed a commit to ngdevelop-tech/angular that referenced this pull request Aug 27, 2019
)

A clang-format plugin for Vim must point to the npm-installed
clang-format command. Add docs for this.

PR Close angular#32254
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
)

A clang-format plugin for Vim must point to the npm-installed
clang-format command. Add docs for this.

PR Close angular#32254
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 22, 2019
arnehoek pushed a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
)

A clang-format plugin for Vim must point to the npm-installed
clang-format command. Add docs for this.

PR Close angular#32254
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours feature Issue that requests a new feature risk: low target: patch This PR is targeted for the next patch release
Projects
docs
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants