Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(language-service): update integration test information #32269

Closed
wants to merge 4 commits into from
Closed

docs(language-service): update integration test information #32269

wants to merge 4 commits into from

Conversation

ayazhafiz
Copy link
Member

The documentation for the langauge service plugin integration test
appears to be stale. Remove section about new versions of TypeScript,
which appear not to be tested, and update the information about
generating and updating goldens to reflect the new way of doing so.
Add information about install deps in the repo root, this directory, and
building Angular before testing.

Also remove trailing whitespace on one line.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

See commit message

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@ayazhafiz ayazhafiz added comp: docs area: language-service Issues related to Angular's VS Code language service target: major This PR is targeted for the next major release labels Aug 22, 2019
@ayazhafiz ayazhafiz requested a review from kyliau August 22, 2019 13:47
@ayazhafiz ayazhafiz requested a review from a team as a code owner August 22, 2019 13:47
@ayazhafiz ayazhafiz self-assigned this Aug 22, 2019
@ngbot ngbot bot modified the milestone: needsTriage Aug 22, 2019
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Aug 22, 2019
@kapunahelewong kapunahelewong added this to In Review in docs Aug 22, 2019
kyliau
kyliau reviewed Aug 22, 2019
View reviewed changes
Copy link
Contributor

@kyliau kyliau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the docs!

integration/language_service_plugin/README.md Outdated Show resolved Hide resolved
@ayazhafiz ayazhafiz requested a review from kyliau August 22, 2019 19:32
josephperrott
josephperrott approved these changes Aug 22, 2019
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval for @angular/fw-integration

@ayazhafiz ayazhafiz added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Aug 24, 2019
@ngbot
Copy link

ngbot bot commented Aug 24, 2019

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: test_zonejs" is failing
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@ayazhafiz
Copy link
Member Author

Caretaker: Please restart test_zonejs or accept as is; it is likely flakey, as these are documentation changes.

@atscott
Copy link
Contributor

atscott commented Aug 26, 2019

Hi Ayaz, looks like CI tests are passing now but merge is blocked by pending review from @jbogarthyde.

jbogarthyde
jbogarthyde suggested changes Aug 26, 2019
View reviewed changes
Copy link
Contributor

@jbogarthyde jbogarthyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor edits

integration/language_service_plugin/README.md Outdated Show resolved Hide resolved
integration/language_service_plugin/README.md Outdated Show resolved Hide resolved
integration/language_service_plugin/README.md Outdated Show resolved Hide resolved
@ayazhafiz
docs(language-service): update integration test information
eb2eb4f 
The documentation for the langauge service plugin integration test
appears to be stale. Remove section about new versions of TypeScript,
which appear not to be tested, and update the information about
generating and updating goldens to reflect the new way of doing so.
Add information about install deps in the repo root, this directory, and
building Angular before testing.

Also remove trailing whitespace on one line.
@ayazhafiz
fixup! docs(language-service): update integration test information
3739eb8
@ayazhafiz
fixup! docs(language-service): update integration test information
5859168
jbogarthyde
jbogarthyde approved these changes Aug 26, 2019
View reviewed changes
Copy link
Contributor

@jbogarthyde jbogarthyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good.

@atscott atscott closed this in f209aac Aug 27, 2019
@jbogarthyde jbogarthyde moved this from In Review to Waiting for Merge in docs Aug 28, 2019
@jbogarthyde jbogarthyde moved this from Waiting for Merge to Done in docs Aug 28, 2019
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
@ayazhafiz @sabeersulaiman
docs(language-service): update integration test information (angular#…
af4a945 
…32269)

The documentation for the langauge service plugin integration test
appears to be stale. Remove section about new versions of TypeScript,
which appear not to be tested, and update the information about
generating and updating goldens to reflect the new way of doing so.
Add information about install deps in the repo root, this directory, and
building Angular before testing.

Also remove trailing whitespace on one line.

PR Close angular#32269
arnehoek pushed a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
@ayazhafiz @arnehoek
docs(language-service): update integration test information (angular#…
cec240e 
…32269)

The documentation for the langauge service plugin integration test
appears to be stale. Remove section about new versions of TypeScript,
which appear not to be tested, and update the information about
generating and updating goldens to reflect the new way of doing so.
Add information about install deps in the repo root, this directory, and
building Angular before testing.

Also remove trailing whitespace on one line.

PR Close angular#32269
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kyliau kyliau kyliau approved these changes

@josephperrott josephperrott josephperrott approved these changes

@jbogarthyde jbogarthyde jbogarthyde approved these changes

Assignees

@ayazhafiz ayazhafiz

Labels
action: merge The PR is ready for merge by the caretaker area: language-service Issues related to Angular's VS Code language service cla: yes effort1: hours merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note risk: low target: major This PR is targeted for the next major release type: bug/fix
Projects
docs
Done
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ayazhafiz @atscott @kyliau @josephperrott @jbogarthyde @kapunahelewong @googlebot