Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix http example to use correct property #32288

Closed

Conversation

kapunahelewong
Copy link
Contributor

@kapunahelewong kapunahelewong commented Aug 23, 2019

Fixes #31814

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: Fixes #31814

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Thanks to @ rakeshkohli for bringing this up. 馃専

@kapunahelewong kapunahelewong requested a review from a team as a code owner August 23, 2019 12:46
@ngbot ngbot bot modified the milestone: Backlog Aug 23, 2019
@kapunahelewong kapunahelewong added the target: patch This PR is targeted for the next patch release label Aug 23, 2019
@mary-poppins
Copy link

You can preview c6b18a6 at https://pr32288-c6b18a6.ngbuilds.io/.

@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Aug 23, 2019
@gkalpak
Copy link
Member

gkalpak commented Aug 23, 2019

merge-assistance: Global approval for this docs-only change.

@atscott atscott closed this in 9bb5f05 Aug 23, 2019
atscott pushed a commit that referenced this pull request Aug 23, 2019
@kapunahelewong kapunahelewong added this to Done in docs Aug 26, 2019
ngdevelop-tech pushed a commit to ngdevelop-tech/angular that referenced this pull request Aug 27, 2019
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 23, 2019
arnehoek pushed a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
@kapunahelewong kapunahelewong deleted the http-example-fix branch June 23, 2020 12:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note risk: low target: patch This PR is targeted for the next patch release type: bug/fix
Projects
docs
Done
Development

Successfully merging this pull request may close these issues.

Issue in Angular example
5 participants