Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix wrong HttpEventType of HttpResponse class #32296

Closed
wants to merge 1 commit into from
Closed

docs: fix wrong HttpEventType of HttpResponse class #32296

wants to merge 1 commit into from

Conversation

chigix
Copy link
Contributor

@chigix chigix commented Aug 24, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@chigix chigix requested a review from a team as a code owner August 24, 2019 09:49
@kapunahelewong kapunahelewong added effort1: hours risk: low type: bug/fix target: patch This PR is targeted for the next patch release labels Aug 26, 2019
kapunahelewong
kapunahelewong approved these changes Aug 26, 2019
View reviewed changes
Copy link
Contributor

@kapunahelewong kapunahelewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for this fix @chigix.

@kapunahelewong kapunahelewong added the action: merge The PR is ready for merge by the caretaker label Aug 26, 2019
@kapunahelewong
Copy link
Contributor

Docs only change.

@kapunahelewong kapunahelewong added this to Waiting for Merge in docs Aug 26, 2019
@atscott atscott closed this in b9fbd9b Aug 26, 2019
atscott pushed a commit that referenced this pull request Aug 26, 2019
@chigix @atscott
docs: fix wrong HttpEventType of HttpResponse class (#32296)
0878d67 
PR Close #32296
@kapunahelewong kapunahelewong moved this from Waiting for Merge to Done in docs Aug 26, 2019
ngdevelop-tech pushed a commit to ngdevelop-tech/angular that referenced this pull request Aug 27, 2019
@chigix @ngdevelop-tech
docs: fix wrong HttpEventType of HttpResponse class (angular#32296)
688c4fa 
PR Close angular#32296
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
@chigix @sabeersulaiman
docs: fix wrong HttpEventType of HttpResponse class (angular#32296)
6cb8705 
PR Close angular#32296
arnehoek pushed a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
@chigix @arnehoek
docs: fix wrong HttpEventType of HttpResponse class (angular#32296)
eccb0ce 
PR Close angular#32296
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kapunahelewong kapunahelewong kapunahelewong approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours risk: low target: patch This PR is targeted for the next patch release type: bug/fix
Projects
docs
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chigix @kapunahelewong @googlebot