Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(platform-browser): remove redundant JSDoc tag from BROWSER_SANITIZATION_PROVIDERS__POST_R3__ #32314

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Aug 26, 2019

The JSDoc tag was introduced in #31934 and was not intentional according to this discussion on Slack.

…TIZATION_PROVIDERS__POST_R3__`

The JSDoc tag was introduced in angular#31934 and was not intentional according
to [this discussion on Slack][1].

[1]: https://angular-team.slack.com/archives/CHB51S90D/p1566322373094100?thread_ts=1566292123.093500&cid=CHB51S90D
@gkalpak gkalpak requested a review from a team as a code owner August 26, 2019 10:09
@gkalpak gkalpak added area: core Issues related to the framework runtime comp: docs action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release refactoring Issue that involves refactoring or code-cleanup labels Aug 26, 2019
@ngbot ngbot bot modified the milestone: needsTriage Aug 26, 2019
@gkalpak gkalpak added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Aug 26, 2019
@mary-poppins
Copy link

You can preview dddb50f at https://pr32314-dddb50f.ngbuilds.io/.

@mhevery mhevery closed this in cc288ae Aug 29, 2019
@gkalpak gkalpak deleted the docs-platform-browser-redundant-jsdoc-tag branch August 29, 2019 10:11
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
…TIZATION_PROVIDERS__POST_R3__` (angular#32314)

The JSDoc tag was introduced in angular#31934 and was not intentional according
to [this discussion on Slack][1].

[1]: https://angular-team.slack.com/archives/CHB51S90D/p1566322373094100?thread_ts=1566292123.093500&cid=CHB51S90D

PR Close angular#32314
arnehoek pushed a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
…TIZATION_PROVIDERS__POST_R3__` (angular#32314)

The JSDoc tag was introduced in angular#31934 and was not intentional according
to [this discussion on Slack][1].

[1]: https://angular-team.slack.com/archives/CHB51S90D/p1566322373094100?thread_ts=1566292123.093500&cid=CHB51S90D

PR Close angular#32314
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes refactoring Issue that involves refactoring or code-cleanup target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants