Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix typo in singleton-services.md page #32330

Closed
wants to merge 1 commit into from

Conversation

gaborszekely
Copy link
Contributor

Fix typo by replacing the word "once" with "one" on the Singleton Services documentation page.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

There is a typo on the Singleton Services documentation page, on the very first line. The sentence reads "A singleton service is a service for which only once instance exists in an app", whereas it should read "A singleton service is a service for which only one instance exists in an app".

Issue Number: N/A

What is the new behavior?

Replace first sentence with the proper word.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

There is a typo in the first sentence of the singleton-service.md documentation page.
@gaborszekely gaborszekely requested a review from a team as a code owner August 27, 2019 01:50
@ngbot ngbot bot modified the milestone: Backlog Aug 27, 2019
@kapunahelewong kapunahelewong added the target: patch This PR is targeted for the next patch release label Aug 27, 2019
@kapunahelewong kapunahelewong added the action: merge The PR is ready for merge by the caretaker label Aug 27, 2019
@kapunahelewong
Copy link
Contributor

Thanks for this, @gaborszekely!

atscott pushed a commit that referenced this pull request Aug 27, 2019
There is a typo in the first sentence of the singleton-service.md documentation page.
PR Close #32330
@atscott atscott closed this in 70cf8ed Aug 27, 2019
@kapunahelewong kapunahelewong added this to Done in docs Aug 28, 2019
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
There is a typo in the first sentence of the singleton-service.md documentation page.
PR Close angular#32330
arnehoek pushed a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
There is a typo in the first sentence of the singleton-service.md documentation page.
PR Close angular#32330
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours risk: low target: patch This PR is targeted for the next patch release type: bug/fix
Projects
docs
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants