Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update i18n docs sample to cater for latest raw-loader version #32334

Closed
wants to merge 2 commits into from
Closed

docs: update i18n docs sample to cater for latest raw-loader version #32334

wants to merge 2 commits into from

Conversation

alan-agius4
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

raw-loader version 2+ which is used in the CLI version 8 introduced a breaking change and now uses export default instead of module.exports.

See: https://github.com/webpack-contrib/raw-loader/blob/master/CHANGELOG.md#200-2019-03-18

Closes #32333

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@alan-agius4 alan-agius4 added comp: docs aio: preview target: patch This PR is targeted for the next patch release labels Aug 27, 2019
@alan-agius4 alan-agius4 requested a review from a team as a code owner August 27, 2019 08:06
@alan-agius4 alan-agius4 changed the title docs: update i18n docs sample to cater for the raw-loader version docs: update i18n docs sample to cater for latest raw-loader version Aug 27, 2019
`raw-loader` version 2+ which is used in the CLI version 8 introduced a breaking change and now uses `export default` instead of `module.exports`.

See: https://github.com/webpack-contrib/raw-loader/blob/master/CHANGELOG.md#200-2019-03-18

Closes #32333
@ngbot ngbot bot added this to the needsTriage milestone Aug 27, 2019
@mary-poppins
Copy link

You can preview 35b3015 at https://pr32334-35b3015.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 09ea2eb at https://pr32334-09ea2eb.ngbuilds.io/.

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Aug 27, 2019
@atscott atscott closed this in 1cb6234 Aug 27, 2019
atscott pushed a commit that referenced this pull request Aug 27, 2019
atscott pushed a commit that referenced this pull request Aug 27, 2019
…32334)

`raw-loader` version 2+ which is used in the CLI version 8 introduced a breaking change and now uses `export default` instead of `module.exports`.

See: https://github.com/webpack-contrib/raw-loader/blob/master/CHANGELOG.md#200-2019-03-18

Closes #32333

PR Close #32334
atscott pushed a commit that referenced this pull request Aug 27, 2019
@alan-agius4 alan-agius4 deleted the docs-raw-loader-i18n branch August 27, 2019 16:11
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
…ngular#32334)

`raw-loader` version 2+ which is used in the CLI version 8 introduced a breaking change and now uses `export default` instead of `module.exports`.

See: https://github.com/webpack-contrib/raw-loader/blob/master/CHANGELOG.md#200-2019-03-18

Closes angular#32333

PR Close angular#32334
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
arnehoek pushed a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
…ngular#32334)

`raw-loader` version 2+ which is used in the CLI version 8 introduced a breaking change and now uses `export default` instead of `module.exports`.

See: https://github.com/webpack-contrib/raw-loader/blob/master/CHANGELOG.md#200-2019-03-18

Closes angular#32333

PR Close angular#32334
arnehoek pushed a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker aio: preview cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular update issue. ( from 7.2.15 to 8.2.3 )
4 participants