Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(language-service): rename host to tsLsHost #32346

Closed
wants to merge 1 commit into from

Conversation

ayazhafiz
Copy link
Member

Disambiguate the name of the Language Service Host used in constructing
a TypeScript Language Service Host by renaming the host property to
tsLsHost.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@ayazhafiz ayazhafiz added refactoring Issue that involves refactoring or code-cleanup area: language-service Issues related to Angular's VS Code language service target: major This PR is targeted for the next major release labels Aug 27, 2019
@ayazhafiz ayazhafiz requested a review from kyliau August 27, 2019 14:53
@ayazhafiz ayazhafiz requested a review from a team as a code owner August 27, 2019 14:53
@ayazhafiz ayazhafiz self-assigned this Aug 27, 2019
@ngbot ngbot bot added this to the needsTriage milestone Aug 27, 2019
Copy link
Contributor

@kyliau kyliau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@kyliau kyliau added the action: merge The PR is ready for merge by the caretaker label Aug 27, 2019
@mhevery
Copy link
Contributor

mhevery commented Aug 29, 2019

please resolve conflict.

Disambiguate the name of the Language Service Host used in constructing
a TypeScript Language Service Host by renaming the `host` property to
`tsLsHost`.
@mhevery mhevery closed this in 47a4edb Aug 29, 2019
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
Disambiguate the name of the Language Service Host used in constructing
a TypeScript Language Service Host by renaming the `host` property to
`tsLsHost`.

PR Close angular#32346
arnehoek pushed a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
Disambiguate the name of the Language Service Host used in constructing
a TypeScript Language Service Host by renaming the `host` property to
`tsLsHost`.

PR Close angular#32346
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: language-service Issues related to Angular's VS Code language service cla: yes refactoring Issue that involves refactoring or code-cleanup target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants