Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix typo in compiler options guide #32348

Closed
wants to merge 1 commit into from
Closed

docs: fix typo in compiler options guide #32348

wants to merge 1 commit into from

Conversation

is2ei
Copy link

@is2ei is2ei commented Aug 27, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

"Angular libraries. |"

Issue Number: N/A

What is the new behavior?

"Angular libraries."

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@is2ei is2ei requested a review from IgorMinar as a code owner August 27, 2019 15:51
@ngbot ngbot bot added this to the needsTriage milestone Aug 27, 2019
@kapunahelewong kapunahelewong added effort1: hours target: patch This PR is targeted for the next patch release risk: low type: bug/fix labels Aug 28, 2019
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Aug 28, 2019
kapunahelewong
kapunahelewong approved these changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@kapunahelewong kapunahelewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thank you, @is2ei!

@kapunahelewong
Copy link
Contributor

Caretaker, this is a docs only change. Thanks!

@kapunahelewong kapunahelewong added the action: merge The PR is ready for merge by the caretaker label Aug 28, 2019
@kapunahelewong kapunahelewong added this to Waiting for Merge in docs Aug 29, 2019
mhevery pushed a commit that referenced this pull request Aug 29, 2019
@mhevery
docs: fix typo in compiler options guide (#32348)
9d2348b 
PR Close #32348
@mhevery mhevery closed this in 03cbce8 Aug 29, 2019
@jbogarthyde jbogarthyde moved this from Waiting for Merge to Done in docs Sep 3, 2019
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
@sabeersulaiman
docs: fix typo in compiler options guide (angular#32348)
3772f4e 
PR Close angular#32348
arnehoek pushed a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
@arnehoek
docs: fix typo in compiler options guide (angular#32348)
aadc3f4 
PR Close angular#32348
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kapunahelewong kapunahelewong kapunahelewong approved these changes

@IgorMinar IgorMinar Awaiting requested review from IgorMinar

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours risk: low target: patch This PR is targeted for the next patch release type: bug/fix
Projects
docs
Done
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@is2ei @kapunahelewong @atscott @googlebot