docs: added note in animation keyframe offset #32350
Conversation
kapunahelewong
added
the
target: patch
|
@kapunahelewong Somehow the pipeline does not like it. Any suggestion? |
|
Hm, a rebase might help. Here are my steps to rebase if you'd like them for reference. Rebasing will hopefully fix those. Will you tag me when you've rebased? If the rebase goes ok and they still fail, at least we'll know we're on the latest and can work from there. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
@kapunahelewong It should be good now, thanks for guidelines. I'll treasure it for the future :) |
|
So glad it worked, @jrumandal 😊 Everything looks good, but we need just one commit in the PR (at the moment, there are two). Could you squash? Here's my workflow for squashing. We're almost there! 🛵 |
Not mentioned in the docs. Whenever offset property is used inside a keyframe's step at least once, then it must be defined to all the steps. When read the first time, I supposed that the API automatically sets an even offset to the remaining not defined offsets, which is not
@kapunahelewong Got it! :) |
|
Caretaker, this is a docs only change. Thank you! |
Not mentioned in the docs. Whenever offset property is used inside a keyframe's step at least once, then it must be defined to all the steps. When read the first time, I supposed that the API automatically sets an even offset to the remaining not defined offsets, which is not PR Close #32350
Not mentioned in the docs. Whenever offset property is used inside a keyframe's step at least once, then it must be defined to all the steps. When read the first time, I supposed that the API automatically sets an even offset to the remaining not defined offsets, which is not PR Close angular#32350
Not mentioned in the docs. Whenever offset property is used inside a keyframe's step at least once, then it must be defined to all the steps. When read the first time, I supposed that the API automatically sets an even offset to the remaining not defined offsets, which is not PR Close angular#32350
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Not mentioned in the docs.
Whenever offset property is used inside a keyframe's step at least once, then it must be defined to all the steps.
When read the first time, I supposed that the API automatically sets an even offset to the remaining not defined offsets, which is not
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information