refactor(core): undecorated-classes-with-decorated-fields migration commits empty updates #32391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ommits empty updates Commit 904a201 introduced a new migration for undecorated classes with decorated Angular class members. Currently the migration always calls `tree.beginUpdate` and `tree.commitUpdate` (even if there are no changes). This causes unnecessary updates to be reported to developers running `ng update`. Once an update is commited, the CLI will report the update regardless of whether any changes were made or not. This behavior can be observed in the `ng_update_migrations` integration test. See: https://circleci.com/gh/angular/angular/438470#tests/containers/3. Notice how all source files are denoted as `UPDATED` (even though there are no changes).
devversion
added
action: review
kara
added
action: presubmit
kara
added
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
kara
added
the
merge: caretaker note
|
merge-assistance: SauceLabs error from master being red earlier |
sabeersulaiman
pushed a commit
to sabeersulaiman/angular
that referenced
this pull request
Sep 6, 2019
…ommits empty updates (angular#32391) Commit 904a201 introduced a new migration for undecorated classes with decorated Angular class members. Currently the migration always calls `tree.beginUpdate` and `tree.commitUpdate` (even if there are no changes). This causes unnecessary updates to be reported to developers running `ng update`. Once an update is commited, the CLI will report the update regardless of whether any changes were made or not. This behavior can be observed in the `ng_update_migrations` integration test. See: https://circleci.com/gh/angular/angular/438470#tests/containers/3. Notice how all source files are denoted as `UPDATED` (even though there are no changes). PR Close angular#32391
arnehoek
pushed a commit
to arnehoek/angular
that referenced
this pull request
Sep 26, 2019
…ommits empty updates (angular#32391) Commit 904a201 introduced a new migration for undecorated classes with decorated Angular class members. Currently the migration always calls `tree.beginUpdate` and `tree.commitUpdate` (even if there are no changes). This causes unnecessary updates to be reported to developers running `ng update`. Once an update is commited, the CLI will report the update regardless of whether any changes were made or not. This behavior can be observed in the `ng_update_migrations` integration test. See: https://circleci.com/gh/angular/angular/438470#tests/containers/3. Notice how all source files are denoted as `UPDATED` (even though there are no changes). PR Close angular#32391
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 904a201 introduced a new migration for undecorated classes with
decorated Angular class members. Currently the migration always calls
tree.beginUpdateandtree.commitUpdate(even if there are no changes).This causes unnecessary updates to be reported to developers running
ng update.Once an update is committed, the CLI will report the update regardless of whether any
changes were made or not.
This behavior can be observed in the
ng_update_migrationsintegration test. See:https://circleci.com/gh/angular/angular/438470#tests/containers/3. Notice how all
source files are denoted as
UPDATED.