Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct @ngtools/webpack url #32407

Closed
wants to merge 1 commit into from
Closed

docs: correct @ngtools/webpack url #32407

wants to merge 1 commit into from

Conversation

tieppt
Copy link
Contributor

@tieppt tieppt commented Aug 30, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Fix Broken link for "Angular Ahead-of-Time Webpack Plugin documentation"
Issue Number: #32385

What is the new behavior?

correct @ngtools/webpack url

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kapunahelewong please review this PR.

@tieppt tieppt requested a review from a team as a code owner August 30, 2019 03:05
@alan-agius4 alan-agius4 added comp: docs target: patch This PR is targeted for the next patch release labels Aug 30, 2019
@ngbot ngbot bot modified the milestone: needsTriage Aug 30, 2019
@alan-agius4
Copy link
Contributor

Thanks for this.

@alan-agius4 alan-agius4 added the state: community Someone from the Angular community is working on this issue or submitted this PR label Aug 30, 2019
Copy link
Contributor

@kapunahelewong kapunahelewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks, @tieppt!

@angular angular deleted a comment from kapunahelewong Sep 3, 2019
@kapunahelewong kapunahelewong added the action: merge The PR is ready for merge by the caretaker label Sep 3, 2019
@kapunahelewong
Copy link
Contributor

Caretaker, this is a docs only change. Thanks!

mhevery pushed a commit that referenced this pull request Sep 3, 2019
@mhevery mhevery closed this in 04d4fea Sep 3, 2019
@tieppt tieppt deleted the fix-i18n-docs branch September 4, 2019 03:17
@kapunahelewong kapunahelewong added this to Done in docs Sep 5, 2019
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
arnehoek pushed a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours risk: low state: community Someone from the Angular community is working on this issue or submitted this PR target: patch This PR is targeted for the next patch release type: bug/fix
Projects
docs
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants