Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(core): typos in docs and tests #32410

Closed
wants to merge 1 commit into from
Closed

style(core): typos in docs and tests #32410

wants to merge 1 commit into from

Conversation

cexbrayat
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

PR #32154 introduced platform and any for providedIn and the doc has a minor typo.
Also a test name was not changed accordingly to the refactoring done.

Does this PR introduce a breaking change?

  • Yes
  • No

@cexbrayat
style(core): typos in docs and tests
64a56cc 
PR angular#32154 introduced `platform` and `any` for `providedIn` and the doc has a minor typo.
Also a test name was not changed accordingly to the refactoring done.
@cexbrayat cexbrayat requested a review from a team as a code owner August 30, 2019 08:21
@mhevery mhevery added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release area: core Issues related to the framework runtime labels Sep 3, 2019
@ngbot ngbot bot added this to the needsTriage milestone Sep 3, 2019
@mhevery mhevery closed this in bdbf0c9 Sep 4, 2019
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
@cexbrayat @sabeersulaiman
style(core): typos in docs and tests (angular#32410)
a4ed595 
PR angular#32154 introduced `platform` and `any` for `providedIn` and the doc has a minor typo.
Also a test name was not changed accordingly to the refactoring done.

PR Close angular#32410
arnehoek pushed a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
@cexbrayat @arnehoek
style(core): typos in docs and tests (angular#32410)
86421d1 
PR angular#32154 introduced `platform` and `any` for `providedIn` and the doc has a minor typo.
Also a test name was not changed accordingly to the refactoring done.

PR Close angular#32410
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhevery mhevery mhevery approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cexbrayat @mhevery @googlebot