build: mention where to find the invalid commit message, when validation fails #32420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion fails Whenever someone tries to commit (by running `git commit` directly or indirectly), a `commit-msg` git hook is run to validate the commit message. If the validation fails, an error message is printed and the commit is aborted. Occasionally, people may have written a non-trivial commit message which could turn out to be invalid (due a small typo for example). In that case, it is frustrating to "lose" the whole message and have to write it all over again (from memory). This is frustrating and has happened to me enough times to finally seek a solution. Fortunately, it turns out that git stores the last commit message in `.git/COMMIT_EDITMSG`, so it is easy to get it back (as long as you know where to look for it). This commit mentions this info in the validation error to help people that might not know about it. (This issue is probably mostly relevant for people using git from the command-line and not through a UI, but it won't hurt in either case.)
gkalpak
added
area: build & ci
josephperrott
approved these changes
Aug 30, 2019
matsko
pushed a commit
that referenced
this pull request
Aug 30, 2019
…ion fails (#32420) Whenever someone tries to commit (by running `git commit` directly or indirectly), a `commit-msg` git hook is run to validate the commit message. If the validation fails, an error message is printed and the commit is aborted. Occasionally, people may have written a non-trivial commit message which could turn out to be invalid (due a small typo for example). In that case, it is frustrating to "lose" the whole message and have to write it all over again (from memory). This is frustrating and has happened to me enough times to finally seek a solution. Fortunately, it turns out that git stores the last commit message in `.git/COMMIT_EDITMSG`, so it is easy to get it back (as long as you know where to look for it). This commit mentions this info in the validation error to help people that might not know about it. (This issue is probably mostly relevant for people using git from the command-line and not through a UI, but it won't hurt in either case.) PR Close #32420
sabeersulaiman
pushed a commit
to sabeersulaiman/angular
that referenced
this pull request
Sep 6, 2019
…ion fails (angular#32420) Whenever someone tries to commit (by running `git commit` directly or indirectly), a `commit-msg` git hook is run to validate the commit message. If the validation fails, an error message is printed and the commit is aborted. Occasionally, people may have written a non-trivial commit message which could turn out to be invalid (due a small typo for example). In that case, it is frustrating to "lose" the whole message and have to write it all over again (from memory). This is frustrating and has happened to me enough times to finally seek a solution. Fortunately, it turns out that git stores the last commit message in `.git/COMMIT_EDITMSG`, so it is easy to get it back (as long as you know where to look for it). This commit mentions this info in the validation error to help people that might not know about it. (This issue is probably mostly relevant for people using git from the command-line and not through a UI, but it won't hurt in either case.) PR Close angular#32420
arnehoek
pushed a commit
to arnehoek/angular
that referenced
this pull request
Sep 26, 2019
…ion fails (angular#32420) Whenever someone tries to commit (by running `git commit` directly or indirectly), a `commit-msg` git hook is run to validate the commit message. If the validation fails, an error message is printed and the commit is aborted. Occasionally, people may have written a non-trivial commit message which could turn out to be invalid (due a small typo for example). In that case, it is frustrating to "lose" the whole message and have to write it all over again (from memory). This is frustrating and has happened to me enough times to finally seek a solution. Fortunately, it turns out that git stores the last commit message in `.git/COMMIT_EDITMSG`, so it is easy to get it back (as long as you know where to look for it). This commit mentions this info in the validation error to help people that might not know about it. (This issue is probably mostly relevant for people using git from the command-line and not through a UI, but it won't hurt in either case.) PR Close angular#32420
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever someone tries to commit (by running
git commitdirectly or indirectly), acommit-msggit hook is run to validate the commit message. If the validation fails, an error message is printed and the commit is aborted.Occasionally, people may have written a non-trivial commit message which could turn out to be invalid (due a small typo for example). In that case, it is frustrating to "lose" the whole message and have to write it all over again (from memory). This is frustrating and has happened to me enough times to finally seek a solution.
Fortunately, it turns out that git stores the last commit message in
.git/COMMIT_EDITMSG, so it is easy to get it back (as long as you know where to look for it). This commit mentions this info in the validation error to help people that might not know about it.(This issue is probably mostly relevant for people using git from the command-line and not through a UI, but it won't hurt in either case.)