refactor(ivy): simplify property binding metadata #32457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkozlowski-opensource
added
comp: ivy
target: major
pkozlowski-opensource
force-pushed
the
binding_metadata_simplify
branch
3 times, most recently
from
51379ba
to
ae750b4
Compare
Since property binding metadata storage is guarded with the ngDevMode now and several instructions were merged together, we can simplify the way we store and read property binding metadata.
pkozlowski-opensource
force-pushed
the
binding_metadata_simplify
branch
from
ae750b4
to
c4ab8f9
Compare
pkozlowski-opensource
added
the
action: review
sabeersulaiman
pushed a commit
to sabeersulaiman/angular
that referenced
this pull request
Sep 6, 2019
) Since property binding metadata storage is guarded with the ngDevMode now and several instructions were merged together, we can simplify the way we store and read property binding metadata. PR Close angular#32457
arnehoek
pushed a commit
to arnehoek/angular
that referenced
this pull request
Sep 26, 2019
) Since property binding metadata storage is guarded with the ngDevMode now and several instructions were merged together, we can simplify the way we store and read property binding metadata. PR Close angular#32457
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since property binding metadata storage is guarded with the ngDevMode now
and several instructions were merged together, we can simplify the way we
store and read property binding metadata.
The the most important change in this PR is that now we can store binding metadata in one field in the
TView.data(previously meta-data for an interpolated bound property would be spread over multipleTView.dataentries). This greatly simplifies property binding metadata retrieval (we just need to look it up at one index) and lets us to remove chunks of code / logic (getFirstBindingIndexcan go away). Also regular and host binding properties gets unified (collectHostPropertyBindingscan be removed).To know where property bindings are located for a given
TNodewe can remove 2 fields fromTNode(propertyMetadataStartIndex/propertyMetadataEndIndex) and replace it with just one (propertyBindings) filled in thengDevModeonly.Finally, property binding metadata are stored for properties only and there is no processing for attribute bindings.
I believe that this refactoring removes code, simplifies logic and opens up possibilities of other refactorings (perf-motivated goal here is to get rid of the
bindfunction).