fix(language-service): create StaticReflector once only #32543
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyliau
added
area: language-service
|
Need to rebase after #32098 is merged |
kyliau
force-pushed
the
static_reflector
branch
6 times, most recently
from
2a154b0
to
f1f7f6b
Compare
kyliau
force-pushed
the
static_reflector
branch
2 times, most recently
from
711222b
to
3fea08a
Compare
5 tasks
mhevery
approved these changes
Oct 3, 2019
petebacondarwin
approved these changes
Oct 3, 2019
kyliau
force-pushed
the
static_reflector
branch
from
3fea08a
to
4c1e2b1
Compare
ayazhafiz
requested changes
Oct 3, 2019
Comment on lines
+186
to
+189
| if (!symbols) { | ||
| return []; | ||
| } | ||
| this.symbolFromFile.delete(fileName); |
There was a problem hiding this comment.
If this is a StaticSymbol[] that is empty, this branch will still be hit right? Maybe we should do a check for undefined so that the file is still deleted from symbolFromFile if not undefined.
There was a problem hiding this comment.
Sorry, I didn't quite get that.. The case of undefined is handled on line 186. If it's an empty array, it should still be deleted from the map, which is handled here.
There was a problem hiding this comment.
my bad; I thought ![] === true
The creation of StaticReflector in createMetadataResolver() is a very expensive operation because it involves numerous module resolutions. To make matter worse, since the API of the Reflector does not provide the ability to invalidate its internal caches, it has to be destroyed and recreated on *every* program change. This has a HUGE impact on performance. This PR fixes this problem by carefully invalidating all StaticSymbols in a file that has changed, thereby reducing the overhead of recomputation on program change.
kyliau
force-pushed
the
static_reflector
branch
from
0886275
to
766964b
Compare
ayazhafiz
approved these changes
Oct 3, 2019
Comment on lines
+186
to
+189
| if (!symbols) { | ||
| return []; | ||
| } | ||
| this.symbolFromFile.delete(fileName); |
There was a problem hiding this comment.
my bad; I thought ![] === true
kara
added
the
merge: caretaker note
|
merge-assistance: misko has global approval |
ODAVING
pushed a commit
to ODAVING/angular
that referenced
this pull request
Oct 18, 2019
The creation of StaticReflector in createMetadataResolver() is a very expensive operation because it involves numerous module resolutions. To make matter worse, since the API of the Reflector does not provide the ability to invalidate its internal caches, it has to be destroyed and recreated on *every* program change. This has a HUGE impact on performance. This PR fixes this problem by carefully invalidating all StaticSymbols in a file that has changed, thereby reducing the overhead of recomputation on program change. PR Close angular#32543
14 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The creation of
StaticReflectorincreateMetadataResolver()is a very expensive operation because it involves numerous module resolutions (on the order of hundreds) to initialize core Angular symbols.Since the API of the Reflector does not provide the ability to invalidate its internal caches,
StaticReflectorhas to be destroyed and recreated on every program change.This has a HUGE impact on performance.
This PR fixes this problem by carefully invalidating all StaticSymbols in a file that has changed, thereby greatly reducing the overhead of recomputation on program change.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information