I18n - compile time inlining #32881

petebacondarwin · 2019-09-27T13:24:08Z

No description provided.

AndrewKushnir · 2019-10-05T00:14:47Z

@petebacondarwin FYI I'm in the process of reviewing this PR, will let you know once it's completed (most likely Monday, 10/7). Thank you.

petebacondarwin · 2019-10-05T07:10:30Z

Thanks Andrew. I am going to tweak the API a bit, today, after discussions with @alan-agius4. But I will add the changes as fixup commits so that it doesn't affect your review if you are going commit by commit.

AndrewKushnir

Very impressive work @petebacondarwin! 👍
I left a few minor comments, none of them are blockers.
Thank you.

packages/localize/src/tools/src/translate/source_files/source_file_utils.ts

...ize/src/tools/src/translate/translation_files/translation_parsers/translation_parse_error.ts

...ools/src/translate/translation_files/translation_parsers/xliff1/xliff1_message_serializer.ts

packages/localize/src/tools/test/translate/integration/BUILD.bazel

AndrewKushnir · 2019-10-08T16:54:06Z

FYI, VE and Ivy presubmits are successful. Thank you.

This commit implements a tool that will inline translations and generate a translated copy of a set of application files from a set of translation files.

IgorMinar

I did a high level review of the PR (general architecture, public api, docs, tests) but didn't check all the details - I'm relying on other reviewers for that.

everything looks good, except for the missing license for babel__core types. Can you please fix that - you can create a new license.md file if one doesn't exist in the original repo, as long as you populate it with the correct licensing info. thanks!

IgorMinar · 2019-10-08T17:42:04Z

packages/localize/src/tools/types/babel/template.d.ts

+  const templateBuilder: DefaultTemplateBuilder;
+
+  export default templateBuilder;
+}


can you please ensure that these typings files don't end up in the built npm packages?

I'm not sure how to configure the Bazel rules to do that...

I'm not either, unfortunately. That would be a good @alexeagle question. I don't know how npm_package determines the set of files to include.

Do references to these types end up in the .d.ts files for the package? If so, it might be very difficult to get the package build to exclude them.

Instead I suggest that we just try to get bazelbuild/rules_nodejs#1033 fixed, which will allow us to remove these typings files altogether.

How about we land this PR now and then work to fix that issue and remove the typings before RC?

Per Igor, this is the approach we'll take. I will merge this PR soon.

@petebacondarwin Is there a Jira for this? Who is working on the Bazel fixes?

@alexeagle is working on the fix as part of the Bazel team. I don't know if there is a JIRA for it. There is not one in the FW JIRA.

ngbot · 2019-10-08T18:33:53Z

I see that you just added the PR action: merge label, but the following checks are still failing:
     status "ci/angular: size" is failing
     status "ci/circleci: build-ivy-npm-packages" is failing
     status "ci/circleci: build-npm-packages" is failing
     status "ci/circleci: test" is failing
     status "ci/circleci: test_ivy_aot" is failing
     forbidden labels detected: PR action: cleanup
     status "google3" is pending
     missing required status "ci/circleci: publish_snapshot"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

IgorMinar · 2019-10-08T18:35:06Z

hmm.. and ci seems to be failing due to duplicate dependencies? @petebacondarwin can you please take a look?

This closer reflects what caused the error.

petebacondarwin · 2019-10-08T22:27:37Z

@IgorMinar - @babel/core typings LICENSE file added

…32881) This closer reflects what caused the error. PR Close #32881

…32881) PR Close #32881

This commit implements a tool that will inline translations and generate a translated copy of a set of application files from a set of translation files. PR Close angular#32881

…ngular#32881) This closer reflects what caused the error. PR Close angular#32881

…ngular#32881) PR Close angular#32881

angular-automatic-lock-bot · 2019-11-10T16:08:04Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

petebacondarwin added action: review The PR is still awaiting reviews from at least one requested reviewer area: i18n target: major This PR is targeted for the next major release comp: ivy labels Sep 27, 2019

ngbot bot added this to the needsTriage milestone Sep 27, 2019

googlebot added the cla: yes label Sep 27, 2019

petebacondarwin mentioned this pull request Sep 27, 2019

I18n localize - compile-time #32105

Closed

14 tasks

petebacondarwin force-pushed the i18n-compile-time branch 6 times, most recently from 13aa1f1 to 97aee88 Compare September 30, 2019 12:18

This was referenced Sep 30, 2019

i18n - extraction tooling #32912

Closed

I18n source maps (proof of concept) #32952

Closed

petebacondarwin force-pushed the i18n-compile-time branch 2 times, most recently from 50f4f23 to 5332292 Compare October 3, 2019 21:07

petebacondarwin marked this pull request as ready for review October 3, 2019 21:10

petebacondarwin requested review from a team as code owners October 3, 2019 21:10

petebacondarwin force-pushed the i18n-compile-time branch 2 times, most recently from e6b796d to 39559c9 Compare October 4, 2019 08:27

petebacondarwin force-pushed the i18n-compile-time branch 3 times, most recently from ee238ab to 6ca46a9 Compare October 7, 2019 07:34

AndrewKushnir approved these changes Oct 8, 2019

View reviewed changes

petebacondarwin force-pushed the i18n-compile-time branch from d4d462f to 4e73f23 Compare October 8, 2019 14:29

AndrewKushnir removed the action: presubmit The PR is in need of a google3 presubmit label Oct 8, 2019

petebacondarwin force-pushed the i18n-compile-time branch from 4e73f23 to fd03a31 Compare October 8, 2019 17:02

feat(ivy): i18n - implement compile-time inlining

abb031d

This commit implements a tool that will inline translations and generate a translated copy of a set of application files from a set of translation files.

petebacondarwin force-pushed the i18n-compile-time branch from fd03a31 to 19b6d96 Compare October 8, 2019 17:47

IgorMinar approved these changes Oct 8, 2019

View reviewed changes

petebacondarwin force-pushed the i18n-compile-time branch from 19b6d96 to 79d7de2 Compare October 8, 2019 22:15

petebacondarwin added 3 commits October 8, 2019 23:18

fixup! feat(ivy): i18n - implement compile-time inlining

02bfae2

refactor(ivy): i18n - rename I18nError to TranslationParserError

ca145a0

This closer reflects what caused the error.

test(ivy): i18n - add compile time translation to integration test

c9e3a8a

petebacondarwin force-pushed the i18n-compile-time branch from 79d7de2 to c9e3a8a Compare October 8, 2019 22:18

fixup! feat(ivy): i18n - implement compile-time inlining

1364441

fixup! feat(ivy): i18n - implement compile-time inlining

b2e811b

alxhub removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Oct 9, 2019

alxhub closed this in 2cdb3a0 Oct 9, 2019

alxhub pushed a commit that referenced this pull request Oct 9, 2019

refactor(ivy): i18n - rename I18nError to TranslationParserError (#…

90855f3

…32881) This closer reflects what caused the error. PR Close #32881

alxhub pushed a commit that referenced this pull request Oct 9, 2019

test(ivy): i18n - add compile time translation to integration test (#…

009cab8

…32881) PR Close #32881

petebacondarwin deleted the i18n-compile-time branch October 9, 2019 20:28

ODAVING pushed a commit to ODAVING/angular that referenced this pull request Oct 18, 2019

refactor(ivy): i18n - rename I18nError to TranslationParserError (a…

9bcdd8f

…ngular#32881) This closer reflects what caused the error. PR Close angular#32881

ODAVING pushed a commit to ODAVING/angular that referenced this pull request Oct 18, 2019

test(ivy): i18n - add compile time translation to integration test (a…

9c0731c

…ngular#32881) PR Close angular#32881

angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 10, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

I18n - compile time inlining #32881

I18n - compile time inlining #32881

petebacondarwin commented Sep 27, 2019 •

edited

AndrewKushnir commented Oct 5, 2019 •

edited

petebacondarwin commented Oct 5, 2019

AndrewKushnir left a comment

AndrewKushnir commented Oct 8, 2019

IgorMinar left a comment

IgorMinar Oct 8, 2019

petebacondarwin Oct 8, 2019

alxhub Oct 8, 2019

petebacondarwin Oct 9, 2019

alxhub Oct 9, 2019

kara Oct 10, 2019

petebacondarwin Oct 10, 2019

ngbot bot commented Oct 8, 2019

IgorMinar commented Oct 8, 2019

petebacondarwin commented Oct 8, 2019

angular-automatic-lock-bot bot commented Nov 10, 2019

I18n - compile time inlining #32881

I18n - compile time inlining #32881

Conversation

petebacondarwin commented Sep 27, 2019 • edited

AndrewKushnir commented Oct 5, 2019 • edited

petebacondarwin commented Oct 5, 2019

AndrewKushnir left a comment

Choose a reason for hiding this comment

AndrewKushnir commented Oct 8, 2019

IgorMinar left a comment

Choose a reason for hiding this comment

IgorMinar Oct 8, 2019

Choose a reason for hiding this comment

petebacondarwin Oct 8, 2019

Choose a reason for hiding this comment

alxhub Oct 8, 2019

Choose a reason for hiding this comment

petebacondarwin Oct 9, 2019

Choose a reason for hiding this comment

alxhub Oct 9, 2019

Choose a reason for hiding this comment

kara Oct 10, 2019

Choose a reason for hiding this comment

petebacondarwin Oct 10, 2019

Choose a reason for hiding this comment

ngbot bot commented Oct 8, 2019

IgorMinar commented Oct 8, 2019

petebacondarwin commented Oct 8, 2019

angular-automatic-lock-bot bot commented Nov 10, 2019

petebacondarwin commented Sep 27, 2019 •

edited

AndrewKushnir commented Oct 5, 2019 •

edited