fix(service-worker): continue serving api requests on cache failure #32996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
added
the
area: service-worker
gkalpak
requested changes
Oct 8, 2019
There was a problem hiding this comment.
Thx, @apocalyp0sys! This goes into the right direction. (Also, love the tests 😍)
I have left a couple of suggestions. In addition, could you split up the PR into two commits: a refactor one to add the lru parameter to safeCacheResponse (since that is actually unrelated to the fix) and a fix one to actually fix the bug?
Make safe caching and unsafe caching methods compatible so they can be swapped. Gives more flexibility when writing http response processing code.
apocalyp0sys
force-pushed
the
fix-ngsw-api-caching-failure
branch
from
b47ae81
to
1f78c57
Compare
gkalpak
requested changes
Oct 14, 2019
There was a problem hiding this comment.
Awesome! Thx for making the changes, @apocalyp0sys 👍
I left a couple more minor comments, but otherwise lgtm 🎉
gkalpak
added
state: WIP
target: patch
apocalyp0sys
force-pushed
the
fix-ngsw-api-caching-failure
branch
from
1f78c57
to
dbcb09c
Compare
When responses are cached ok during sw initialization, but caching throws an error when handling api response, this response never gets to client. Fix response delivery by catching errors, add logging and 2 test cases. Fixes angular#21412
apocalyp0sys
force-pushed
the
fix-ngsw-api-caching-failure
branch
from
dbcb09c
to
df1e2df
Compare
gkalpak
approved these changes
Oct 14, 2019
gkalpak
added
action: merge
mhevery
added
target: major
|
I was unable to merge this to the patch branch as it causes conflicts. Could we create a new PR for patch branch? |
|
Should i create a new PR targeting |
|
Yes, please, @apocalyp0sys 🙏 |
apocalyp0sys
added a commit
to apocalyp0sys/angular
that referenced
this pull request
Oct 15, 2019
…le (angular#32996) Make safe caching and unsafe caching methods compatible so they can be swapped. Gives more flexibility when writing http response processing code. PR Close angular#32996 (cherry picked from commit 1353afc)
apocalyp0sys
added a commit
to apocalyp0sys/angular
that referenced
this pull request
Oct 15, 2019
When responses are cached ok during sw initialization, but caching throws an error when handling api response, this response never gets to client. Fix response delivery by catching errors, add logging and 2 test cases. Same changes for master branch in PR angular#32996 Fixes angular#21412
Closed
3 tasks
ODAVING
pushed a commit
to ODAVING/angular
that referenced
this pull request
Oct 18, 2019
…le (angular#32996) Make safe caching and unsafe caching methods compatible so they can be swapped. Gives more flexibility when writing http response processing code. PR Close angular#32996
ODAVING
pushed a commit
to ODAVING/angular
that referenced
this pull request
Oct 18, 2019
…ngular#32996) When responses are cached ok during sw initialization, but caching throws an error when handling api response, this response never gets to client. Fix response delivery by catching errors, add logging and 2 test cases. Fixes angular#21412 PR Close angular#32996
AndrusGerman
pushed a commit
to AndrusGerman/angular
that referenced
this pull request
Oct 22, 2019
…le (angular#32996) Make safe caching and unsafe caching methods compatible so they can be swapped. Gives more flexibility when writing http response processing code. PR Close angular#32996
AndrusGerman
pushed a commit
to AndrusGerman/angular
that referenced
this pull request
Oct 22, 2019
…ngular#32996) When responses are cached ok during sw initialization, but caching throws an error when handling api response, this response never gets to client. Fix response delivery by catching errors, add logging and 2 test cases. Fixes angular#21412 PR Close angular#32996
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When responses are cached ok during sw initialization, but caching throws an error when handling api response, this response never gets to client.
Issue Number: #21412
What is the new behavior?
Fix response delivery by catching errors and add 2 test cases.
Does this PR introduce a breaking change?