fix(compiler): absolute source span for template attribute expressions #33189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the absolute spans (relative to template source file rather than the start of an expression) of expressions in a template attribute like `*ngIf` were generated incorrectly, equating to the relative spans. This fixes the bug by passing an `absoluteOffset` parameter when parsing template bindings. Through some levels of indirection, this is required for the Language Service to support text replacement in angular#33091.
ayazhafiz
added
type: bug/fix
target: major
kyliau
approved these changes
Oct 15, 2019
JoostK
approved these changes
Oct 16, 2019
petebacondarwin
approved these changes
Oct 17, 2019
kara
added
action: merge
kara
removed
the
merge: caretaker note
|
@matsko I ran a presubmit for this PR earlier: https://test.corp.google.com/ui#id=OCL:275327017:BASE:275327084:1571344272722:e8b0bb92 |
ODAVING
pushed a commit
to ODAVING/angular
that referenced
this pull request
Oct 18, 2019
angular#33189) Prior to this commit, the absolute spans (relative to template source file rather than the start of an expression) of expressions in a template attribute like `*ngIf` were generated incorrectly, equating to the relative spans. This fixes the bug by passing an `absoluteOffset` parameter when parsing template bindings. Through some levels of indirection, this is required for the Language Service to support text replacement in angular#33091. PR Close angular#33189
AndrusGerman
pushed a commit
to AndrusGerman/angular
that referenced
this pull request
Oct 22, 2019
angular#33189) Prior to this commit, the absolute spans (relative to template source file rather than the start of an expression) of expressions in a template attribute like `*ngIf` were generated incorrectly, equating to the relative spans. This fixes the bug by passing an `absoluteOffset` parameter when parsing template bindings. Through some levels of indirection, this is required for the Language Service to support text replacement in angular#33091. PR Close angular#33189
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the absolute spans (relative to template source
file rather than the start of an expression) of expressions in a
template attribute like
*ngIfwere generated incorrectly, equating tothe relative spans.
This fixes the bug by passing an
absoluteOffsetparameter when parsingtemplate bindings.
Through some levels of indirection, this is required for the Language
Service to support text replacement in #33091.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?