New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(compiler-cli): Pass SourceFile to getLeadingTriviaWidth #33588
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a crash in the Angular Kythe indexer caused by failure to retrieve `SourceFile` in a `Statement`. Crash logs: TypeError: Cannot read property 'text' of undefined at Object.getTokenPosOfNode (typescript/stable/lib/typescript.js:8957:72) at NodeObject.getStart (typescript/stable/lib/typescript.js:121419:23) at NodeObject.getLeadingTriviaWidth (typescript/stable/lib/typescript.js:121439:25) at FactoryGenerator.generate (angular2/rc/packages/compiler-cli/src/ngtsc/shims/src/factory_generator.ts:64:49) at GeneratedShimsHostWrapper.getSourceFile (angular2/rc/packages/compiler-cli/src/ngtsc/shims/src/host.ts:88:26) at findSourceFile (typescript/stable/lib/typescript.js:90654:29) at typescript/stable/lib/typescript.js:90553:85 at getSourceFileFromReferenceWorker (typescript/stable/lib/typescript.js:90520:34) at processSourceFile (typescript/stable/lib/typescript.js:90553:13) at processRootFile (typescript/stable/lib/typescript.js:90383:13)
kyliau
added
the
area: compiler
Issues related to `ngc`, Angular's template compiler
label
Nov 5, 2019
AndrewKushnir
approved these changes
Nov 5, 2019
kyliau
added
action: merge
The PR is ready for merge by the caretaker
merge: caretaker note
Alert the caretaker performing the merge to check the PR for an out of normal action needed or note
labels
Nov 5, 2019
alxhub
approved these changes
Nov 5, 2019
kyliau
removed
the
merge: caretaker note
Alert the caretaker performing the merge to check the PR for an out of normal action needed or note
label
Nov 5, 2019
atscott
added
target: patch
This PR is targeted for the next patch release
and removed
target: major
This PR is targeted for the next major release
labels
Nov 5, 2019
atscott
pushed a commit
that referenced
this pull request
Nov 5, 2019
This commit fixes a crash in the Angular Kythe indexer caused by failure to retrieve `SourceFile` in a `Statement`. Crash logs: TypeError: Cannot read property 'text' of undefined at Object.getTokenPosOfNode (typescript/stable/lib/typescript.js:8957:72) at NodeObject.getStart (typescript/stable/lib/typescript.js:121419:23) at NodeObject.getLeadingTriviaWidth (typescript/stable/lib/typescript.js:121439:25) at FactoryGenerator.generate (angular2/rc/packages/compiler-cli/src/ngtsc/shims/src/factory_generator.ts:64:49) at GeneratedShimsHostWrapper.getSourceFile (angular2/rc/packages/compiler-cli/src/ngtsc/shims/src/host.ts:88:26) at findSourceFile (typescript/stable/lib/typescript.js:90654:29) at typescript/stable/lib/typescript.js:90553:85 at getSourceFileFromReferenceWorker (typescript/stable/lib/typescript.js:90520:34) at processSourceFile (typescript/stable/lib/typescript.js:90553:13) at processRootFile (typescript/stable/lib/typescript.js:90383:13) PR Close #33588
mohaxspb
pushed a commit
to mohaxspb/angular
that referenced
this pull request
Nov 7, 2019
…33588) This commit fixes a crash in the Angular Kythe indexer caused by failure to retrieve `SourceFile` in a `Statement`. Crash logs: TypeError: Cannot read property 'text' of undefined at Object.getTokenPosOfNode (typescript/stable/lib/typescript.js:8957:72) at NodeObject.getStart (typescript/stable/lib/typescript.js:121419:23) at NodeObject.getLeadingTriviaWidth (typescript/stable/lib/typescript.js:121439:25) at FactoryGenerator.generate (angular2/rc/packages/compiler-cli/src/ngtsc/shims/src/factory_generator.ts:64:49) at GeneratedShimsHostWrapper.getSourceFile (angular2/rc/packages/compiler-cli/src/ngtsc/shims/src/host.ts:88:26) at findSourceFile (typescript/stable/lib/typescript.js:90654:29) at typescript/stable/lib/typescript.js:90553:85 at getSourceFileFromReferenceWorker (typescript/stable/lib/typescript.js:90520:34) at processSourceFile (typescript/stable/lib/typescript.js:90553:13) at processRootFile (typescript/stable/lib/typescript.js:90383:13) PR Close angular#33588
mohaxspb
pushed a commit
to mohaxspb/angular
that referenced
this pull request
Nov 7, 2019
…33588) This commit fixes a crash in the Angular Kythe indexer caused by failure to retrieve `SourceFile` in a `Statement`. Crash logs: TypeError: Cannot read property 'text' of undefined at Object.getTokenPosOfNode (typescript/stable/lib/typescript.js:8957:72) at NodeObject.getStart (typescript/stable/lib/typescript.js:121419:23) at NodeObject.getLeadingTriviaWidth (typescript/stable/lib/typescript.js:121439:25) at FactoryGenerator.generate (angular2/rc/packages/compiler-cli/src/ngtsc/shims/src/factory_generator.ts:64:49) at GeneratedShimsHostWrapper.getSourceFile (angular2/rc/packages/compiler-cli/src/ngtsc/shims/src/host.ts:88:26) at findSourceFile (typescript/stable/lib/typescript.js:90654:29) at typescript/stable/lib/typescript.js:90553:85 at getSourceFileFromReferenceWorker (typescript/stable/lib/typescript.js:90520:34) at processSourceFile (typescript/stable/lib/typescript.js:90553:13) at processRootFile (typescript/stable/lib/typescript.js:90383:13) PR Close angular#33588
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
area: compiler
Issues related to `ngc`, Angular's template compiler
cla: yes
target: patch
This PR is targeted for the next patch release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a crash in the Angular Kythe indexer caused by failure
to retrieve
SourceFile
in aStatement
.Crash logs:
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information