Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update .nvmrc to correct node version #33636

Closed
wants to merge 1 commit into from

Conversation

josephperrott
Copy link
Member

No description provided.

@josephperrott josephperrott requested a review from a team as a code owner November 6, 2019 21:19
@josephperrott josephperrott added area: build & ci Related the build and CI infrastructure of the project action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Nov 6, 2019
@ngbot ngbot bot modified the milestone: needsTriage Nov 6, 2019
@atscott atscott closed this in a20979d Nov 6, 2019
atscott pushed a commit that referenced this pull request Nov 6, 2019
@josephperrott josephperrott deleted the nvm-update branch November 6, 2019 21:28
@@ -1 +1 @@
10.9.0
10.13.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this version the correct one? 😕

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the version the error message said we should be using 😄

The error message was however informed by the updated requirements in @angular-devkit/architect@0.900.0-rc.0. When we attempted to release we were using node 10.9.0, it failed.

mohaxspb pushed a commit to mohaxspb/angular that referenced this pull request Nov 7, 2019
mohaxspb pushed a commit to mohaxspb/angular that referenced this pull request Nov 7, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants