Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add @angular/localize to ng-update packageGroup #33721

Closed
wants to merge 1 commit into from
Closed

build: add @angular/localize to ng-update packageGroup #33721

wants to merge 1 commit into from

Conversation

alan-agius4
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@alan-agius4 alan-agius4 requested a review from a team as a code owner November 11, 2019 06:54
@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release area: build & ci Related the build and CI infrastructure of the project area: packaging Issues related to Angular's creation of npm packages labels Nov 11, 2019
@ngbot ngbot bot modified the milestone: needsTriage Nov 11, 2019
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker PR action: time-zone labels Nov 11, 2019
josephperrott
josephperrott approved these changes Nov 11, 2019
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara closed this in a8f9ff5 Nov 11, 2019
kara pushed a commit that referenced this pull request Nov 11, 2019
@alan-agius4 @kara
build: add @angular/localize to ng-update packageGroup (#33721)
343483c 
PR Close #33721
@alan-agius4 alan-agius4 deleted the localize-package-group branch November 11, 2019 17:42
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@filipesilva filipesilva filipesilva approved these changes

@devversion devversion devversion approved these changes

@josephperrott josephperrott josephperrott approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project area: packaging Issues related to Angular's creation of npm packages cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alan-agius4 @filipesilva @devversion @josephperrott @googlebot