Monorepository import support #33828
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxhub
added
action: merge
JoostK
approved these changes
Nov 14, 2019
packages/compiler-cli/src/ngtsc/file_system/testing/src/mock_file_system.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/src/ngtsc/file_system/testing/src/mock_file_system.ts
Outdated
Show resolved
Hide resolved
| new LogicalProjectStrategy(this.reflector, new LogicalFileSystem(this.rootDirs)); | ||
| } else { | ||
| // Plain relative imports are all that's needed. | ||
| localImportStrategy = new RelativePathStrategy(this.reflector); |
There was a problem hiding this comment.
I think you should be able to replace the LocigalProjectStrategy with RelativePath strategy within ngcc, as I recall there being a TODO there and this new strategy looks to implement exactly that.
There was a problem hiding this comment.
You're right that there is. But looking at this makes me wonder.
Right now LogicalProjectStrategy protects ngcc from emitting a relative import that points outside of the current entrypoint (and thus outside of the current package). This seems like it might be a reasonable assertion to make. I'll leave it as-is for now, and we can examine the tradeoffs here in another PR. I don't wanna couple this important fix to that decision.
JoostK
added
the
action: cleanup
filipesilva
added a commit
to filipesilva/dashboard
that referenced
this pull request
Nov 15, 2019
alxhub
force-pushed
the
ngtsc/mono/relative
branch
from
28499d9
to
87aa0f7
Compare
This commit adds the ability to change directories using the compiler's internal filesystem abstraction. This is a prerequisite for writing tests which are sensitive to the current working directory. In addition to supporting the `chdir()` operation, this commit also fixes `getDefaultLibLocation()` for mock filesystems to not assume `node_modules` is in the current directory, but to resolve it similarly to how Node does by progressively looking higher in the directory tree.
Previously, the compiler assumed that all TS files logically within a project existed under one or more "root directories". If the TS compiler option `rootDir` or `rootDirs` was set, they would dictate the root directories in use, otherwise the current directory was used. Unfortunately this assumption was unfounded - it's common for projects without explicit `rootDirs` to import from files outside the current working directory. In such cases the `LogicalProjectStrategy` would attempt to generate imports into those files, and fail. This would lead to no `ReferenceEmitStrategy` being able to generate an import, and end in a compiler assertion failure. This commit introduces a new strategy to use when there are no `rootDirs` explicitly present, the `RelativePathStrategy`. It uses simpler, filesystem- relative paths to generate imports, even to files above the current working directory. Fixes angular#33659 Fixes angular#33562
alxhub
force-pushed
the
ngtsc/mono/relative
branch
from
87aa0f7
to
2662c77
Compare
alxhub
removed
the
action: cleanup
|
Presubmit |
alxhub
added a commit
that referenced
this pull request
Nov 19, 2019
…3828) Previously, the compiler assumed that all TS files logically within a project existed under one or more "root directories". If the TS compiler option `rootDir` or `rootDirs` was set, they would dictate the root directories in use, otherwise the current directory was used. Unfortunately this assumption was unfounded - it's common for projects without explicit `rootDirs` to import from files outside the current working directory. In such cases the `LogicalProjectStrategy` would attempt to generate imports into those files, and fail. This would lead to no `ReferenceEmitStrategy` being able to generate an import, and end in a compiler assertion failure. This commit introduces a new strategy to use when there are no `rootDirs` explicitly present, the `RelativePathStrategy`. It uses simpler, filesystem- relative paths to generate imports, even to files above the current working directory. Fixes #33659 Fixes #33562 PR Close #33828
alxhub
added a commit
that referenced
this pull request
Nov 19, 2019
…33828) This commit adds the ability to change directories using the compiler's internal filesystem abstraction. This is a prerequisite for writing tests which are sensitive to the current working directory. In addition to supporting the `chdir()` operation, this commit also fixes `getDefaultLibLocation()` for mock filesystems to not assume `node_modules` is in the current directory, but to resolve it similarly to how Node does by progressively looking higher in the directory tree. PR Close #33828
alxhub
added a commit
that referenced
this pull request
Nov 19, 2019
…3828) Previously, the compiler assumed that all TS files logically within a project existed under one or more "root directories". If the TS compiler option `rootDir` or `rootDirs` was set, they would dictate the root directories in use, otherwise the current directory was used. Unfortunately this assumption was unfounded - it's common for projects without explicit `rootDirs` to import from files outside the current working directory. In such cases the `LogicalProjectStrategy` would attempt to generate imports into those files, and fail. This would lead to no `ReferenceEmitStrategy` being able to generate an import, and end in a compiler assertion failure. This commit introduces a new strategy to use when there are no `rootDirs` explicitly present, the `RelativePathStrategy`. It uses simpler, filesystem- relative paths to generate imports, even to files above the current working directory. Fixes #33659 Fixes #33562 PR Close #33828
6 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❤️