Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(facade): move facade into separate top-level module #3415

Closed
jeffbcross opened this issue Jul 30, 2015 · 5 comments
Closed

refactor(facade): move facade into separate top-level module #3415

jeffbcross opened this issue Jul 30, 2015 · 5 comments
Labels
effort2: days refactoring Issue that involves refactoring or code-cleanup

Comments

@jeffbcross
Copy link
Contributor

In the process of moving Http into its own module (#2680), there is still a requirement to depend on angular2 because of facades and dependency injection. The facades should be moved into their own top-level package so that other top-level modules will not need to depend on all of Angular2.

Right now, I'm planning to take this on after I finish #2680, since the process will be fresh in my head. But I'm waiting to self-assign until I clear some things off my plate.

@jeffbcross jeffbcross added comp: core effort2: days refactoring Issue that involves refactoring or code-cleanup labels Jul 30, 2015
@rolandjitsu
Copy link

👍 It would be really nice to have it, I tend to use many of the methods exposed by the facade, especially all the wrappers.

@PatrickJS
Copy link
Member

great idea for 3rd party modules that also want to support ts and dart

@jeffbcross
Copy link
Contributor Author

Bad news, fellas, it's going to stay in core for now. It's not really a thing we want to maintain and support for outside folks, and I doubt there will be significant interest in building libs that target both JS and Dart. It will still be in the core and could pretty easily be consumed by installing the angular2 package and moving it into its own module though. If later on it becomes apparent that there's value to separating it, there's no reason we couldn't do it at that time.

@jeffbcross
Copy link
Contributor Author

The good news is, ts2dart keeps improving and the facade is getting smaller and less necessary.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
effort2: days refactoring Issue that involves refactoring or code-cleanup
Projects
None yet
Development

No branches or pull requests

3 participants