docs(core): describe your change... #34513
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapunahelewong
added
comp: docs
effort1: hours
target: patch
kapunahelewong
added
the
state: needs eng review
kapunahelewong
moved this from Pending - Top of backlog
to Need Assistance from Eng.
in docs
According to https://angular.io/guide/lifecycle-hooks#ondestroy "Put cleanup logic in ngOnDestroy(), the logic that must run before Angular destroys the directive."
mhevery
approved these changes
Feb 26, 2020
mhevery
pushed a commit
that referenced
this pull request
Feb 26, 2020
According to https://angular.io/guide/lifecycle-hooks#ondestroy "Put cleanup logic in ngOnDestroy(), the logic that must run before Angular destroys the directive." PR Close #34513
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://angular.io/guide/lifecycle-hooks#ondestroy
"Put cleanup logic in ngOnDestroy(), the logic that must run before Angular destroys the directive."
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
These two sections of the docs are in disagreement. I investigated and believe this is now correctly describing the behavior.
Issue Number: N/A
What is the new behavior?
Document that ngOnDestroy runs before the directive is destroyed.
Does this PR introduce a breaking change?
Other information